Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http_proxy and create_table_enabled config options #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HLH15
Copy link

@HLH15 HLH15 commented Mar 18, 2021

Add config options for

  • http_proxy: DynamoDB http_proxy
  • create_table_enabled: to avoid creating tables in DynamoDB directly through Dynamoid. This is useful if one uses external tool to manage DynamoDB tables, eg. terraform.

@andrykonchin
Copy link
Member

andrykonchin commented Mar 31, 2021

Could you please fix the failing specs? Current master passes specs successfuly.

@HLH15
Copy link
Author

HLH15 commented Apr 14, 2021

Could you please fix the failing specs? Current master passes specs successfuly.

@andrykonchin This is fixed now!

@andrykonchin
Copy link
Member

It looks good to me. But I am wondering what a use case for disabling table creation.

I assume it makes sense to prevent lazy table creation at model saving. In this case, it can be checked right here in the #save method

@HLH15
Copy link
Author

HLH15 commented Apr 14, 2021

It looks good to me. But I am wondering what a use case for disabling table creation.

I assume it makes sense to prevent lazy table creation at model saving. In this case, it can be checked right here in the #save method

In our use case, we have a different pipeline to manage all AWS resources (Terraform). So we'd like to prevent creating new tables in all use cases from Dynamoid.

@andrykonchin
Copy link
Member

I see. I would prefer to change the #save method instead of the #create_table. Also, I think we need to add tests on #save and #create and check that table isn't created implicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants