#i2016 slowpath-aarch64-port inital #2411

gregcawthorne · 2021-06-30T13:07:54Z

AArch64 port of drmemory.

Only contains slowpath support with shared_slowpath off.

Pattern mode and fastpath modes are being worked on separately.

Currently this build does break some x86 functionality.

Depends on:
https://github.com/DynamoRIO/dynamorio/tree/mem-ref-for-clean-calls-aarch64/core

Current tests we have analysed:
Test project /home/grecaw01/APD-testing/drmem-upstream3/drmemory/build
Start 1: drmf_proj
1/49 Test #1: drmf_proj ......................... Passed Start 2: unit_tests
2/49 Test #2: unit_tests ........................ Passed Start 3: hello
3/49 Test #3: hello ............................. Passed Start 4: free
4/49 Test #4: free .............................. Passed Start 5: malloc
5/49 Test #5: malloc ............................ Passed Start 6: leak_indirect
6/49 Test #6: leak_indirect ..................... Passed Start 7: patterns
7/49 Test #7: patterns .......................... Passed Start 8: free.exitcode
8/49 Test #8: free.exitcode ..................... Passed Start 9: track_origins
9/49 Test #9: track_origins .....................***Failed Start 10: free.pattern
10/49 Test #10: free.pattern ......................***Failed Start 11: malloc.pattern
11/49 Test #11: malloc.pattern ....................***Failed Start 12: track_origins.pattern
12/49 Test #12: track_origins.pattern .............***Failed Start 13: fuzz_corpus
13/49 Test #13: fuzz_corpus ....................... Passed Start 14: fuzz_buffer
14/49 Test #14: fuzz_buffer ....................... Passed Start 15: fuzz_buffer.replace_buffer
15/49 Test #15: fuzz_buffer.replace_buffer ........ Passed Start 16: fuzz_buffer.overflow
16/49 Test #16: fuzz_buffer.overflow ..............***Failed Start 17: fuzz_buffer.mutator.o-b-s-3
17/49 Test #17: fuzz_buffer.mutator.o-b-s-3 ....... Passed Start 18: fuzz_buffer.mutator.r-b-s-3
18/49 Test #18: fuzz_buffer.mutator.r-b-s-3 ....... Passed Start 19: fuzz_buffer.mutator.o-b-3
19/49 Test #19: fuzz_buffer.mutator.o-b-3 ......... Passed Start 20: fuzz_buffer.mutator.r-n
20/49 Test #20: fuzz_buffer.mutator.r-n ........... Passed Start 21: fuzz_buffer.mutator.random_seed
21/49 Test #21: fuzz_buffer.mutator.random_seed ... Passed Start 22: fuzz_buffer.one-input
22/49 Test #22: fuzz_buffer.one-input ............. Passed Start 23: fuzz_buffer.load_input
23/49 Test #23: fuzz_buffer.load_input ............ Passed Start 24: fuzz_buffer.skip_initial
24/49 Test #24: fuzz_buffer.skip_initial .......... Passed Start 25: fuzz_buffer.fixed_size
25/49 Test #25: fuzz_buffer.fixed_size ............ Passed Start 26: fuzz_buffer.offset
26/49 Test #26: fuzz_buffer.offset ................ Passed Start 27: fuzz_buffer.module_name
27/49 Test #27: fuzz_buffer.module_name ........... Passed Start 28: fuzz_buffer.dictionary
28/49 Test #28: fuzz_buffer.dictionary ............ Passed Start 29: fuzz_buffer.cpp
29/49 Test #29: fuzz_buffer.cpp ................... Start 30: fuzz_custom_mutator
30/49 Test #30: fuzz_custom_mutator ............... Passed Start 31: drsyscall_test
31/49 Test #31: drsyscall_test .................... Passed Start 32: strace_test
32/49 Test #32: strace_test ....................... Passed Start 33: drfuzz_test_empty
33/49 Test #33: drfuzz_test_empty ................. Passed Start 34: drfuzz_test_mutator
34/49 Test #34: drfuzz_test_mutator ............... Passed Start 35: drfuzz_test_repeat
35/49 Test #35: drfuzz_test_repeat ................***Failed Start 36: drfuzz_test_segfault
36/49 Test #36: drfuzz_test_segfault .............. Passed Start 37: drfuzz_test_app_abort
37/49 Test #37: drfuzz_test_app_abort ............. Passed Start 38: drfuzz_test_no_crash
38/49 Test #38: drfuzz_test_no_crash .............. Passed Start 39: umbra_test_empty
39/49 Test #39: umbra_test_empty .................. Passed Start 40: umbra_test_overlap
40/49 Test #40: umbra_test_overlap ................ Passed Start 41: umbra_test_shadow_mem
41/49 Test #41: umbra_test_shadow_mem ............. Passed Start 42: umbra_test_insert_app_to_shadow
42/49 Test #42: umbra_test_insert_app_to_shadow ... Passed Start 43: umbra_test_consistency
43/49 Test #43: umbra_test_consistency ............ Passed Start 44: umbra_test_allscales
44/49 Test #44: umbra_test_allscales .............. Passed Start 45: drltrace
45/49 Test #45: drltrace .......................... Passed Start 46: drltrace_libcalls
46/49 Test #46: drltrace_libcalls ................. Passed Start 47: drltrace_symargs
47/49 Test #47: drltrace_symargs .................. Passed Start 48: drltrace_libargs
48/49 Test #48: drltrace_libargs .................. Passed Start 49: strace_sample
49/49 Test #49: strace_sample ..................... Passed 0.45 sec
0.02 sec
3.55 sec
3.67 sec
3.88 sec
3.52 sec
3.93 sec
3.64 sec
0.34 sec
0.35 sec
0.34 sec
0.34 sec
3.56 sec
4.62 sec
4.62 sec
0.34 sec
4.59 sec
4.63 sec
4.60 sec
4.54 sec
4.57 sec
3.82 sec
3.81 sec
4.01 sec
5.36 sec
5.42 sec
4.58 sec
4.20 sec
Passed 17.77 sec
4.57 sec
0.22 sec
0.22 sec
0.22 sec
2.38 sec

0.20 sec
0.22 sec
0.22 sec
0.22 sec
0.23 sec
0.30 sec
0.29 sec
0.30 sec
0.39 sec
0.35 sec
0.36 sec
0.36 sec
0.35 sec
0.22 sec

88% tests passed, 6 tests failed out of 49

AArch64 port of drmemory. Only contains slowpath support with shared_slowpath off. Pattern mode and fastpath modes are being worked on separately. Currently this build does break some x86 functionality. Depends on: https://github.com/DynamoRIO/dynamorio/tree/mem-ref-for-clean-calls-aarch64/core Current tests we have analysed: Test project /home/grecaw01/APD-testing/drmem-upstream3/drmemory/build Start 1: drmf_proj 1/49 Test #1: drmf_proj ......................... Passed 0.45 sec Start 2: unit_tests 2/49 Test #2: unit_tests ........................ Passed 0.02 sec Start 3: hello 3/49 Test #3: hello ............................. Passed 3.55 sec Start 4: free 4/49 Test #4: free .............................. Passed 3.67 sec Start 5: malloc 5/49 Test #5: malloc ............................ Passed 3.88 sec Start 6: leak_indirect 6/49 Test #6: leak_indirect ..................... Passed 3.52 sec Start 7: patterns 7/49 Test #7: patterns .......................... Passed 3.93 sec Start 8: free.exitcode 8/49 Test #8: free.exitcode ..................... Passed 3.64 sec Start 9: track_origins 9/49 Test #9: track_origins .....................***Failed 0.34 sec Start 10: free.pattern 10/49 Test #10: free.pattern ......................***Failed 0.35 sec Start 11: malloc.pattern 11/49 Test #11: malloc.pattern ....................***Failed 0.34 sec Start 12: track_origins.pattern 12/49 Test #12: track_origins.pattern .............***Failed 0.34 sec Start 13: fuzz_corpus 13/49 Test #13: fuzz_corpus ....................... Passed 3.56 sec Start 14: fuzz_buffer 14/49 Test #14: fuzz_buffer ....................... Passed 4.62 sec Start 15: fuzz_buffer.replace_buffer 15/49 Test #15: fuzz_buffer.replace_buffer ........ Passed 4.62 sec Start 16: fuzz_buffer.overflow 16/49 Test #16: fuzz_buffer.overflow ..............***Failed 0.34 sec Start 17: fuzz_buffer.mutator.o-b-s-3 17/49 Test #17: fuzz_buffer.mutator.o-b-s-3 ....... Passed 4.59 sec Start 18: fuzz_buffer.mutator.r-b-s-3 18/49 Test #18: fuzz_buffer.mutator.r-b-s-3 ....... Passed 4.63 sec Start 19: fuzz_buffer.mutator.o-b-3 19/49 Test #19: fuzz_buffer.mutator.o-b-3 ......... Passed 4.60 sec Start 20: fuzz_buffer.mutator.r-n 20/49 Test #20: fuzz_buffer.mutator.r-n ........... Passed 4.54 sec Start 21: fuzz_buffer.mutator.random_seed 21/49 Test #21: fuzz_buffer.mutator.random_seed ... Passed 4.57 sec Start 22: fuzz_buffer.one-input 22/49 Test #22: fuzz_buffer.one-input ............. Passed 3.82 sec Start 23: fuzz_buffer.load_input 23/49 Test #23: fuzz_buffer.load_input ............ Passed 3.81 sec Start 24: fuzz_buffer.skip_initial 24/49 Test #24: fuzz_buffer.skip_initial .......... Passed 4.01 sec Start 25: fuzz_buffer.fixed_size 25/49 Test #25: fuzz_buffer.fixed_size ............ Passed 5.36 sec Start 26: fuzz_buffer.offset 26/49 Test #26: fuzz_buffer.offset ................ Passed 5.42 sec Start 27: fuzz_buffer.module_name 27/49 Test #27: fuzz_buffer.module_name ........... Passed 4.58 sec Start 28: fuzz_buffer.dictionary 28/49 Test #28: fuzz_buffer.dictionary ............ Passed 4.20 sec Start 29: fuzz_buffer.cpp 29/49 Test #29: fuzz_buffer.cpp ................... Passed 17.77 sec Start 30: fuzz_custom_mutator 30/49 Test #30: fuzz_custom_mutator ............... Passed 4.57 sec Start 31: drsyscall_test 31/49 Test #31: drsyscall_test .................... Passed 0.22 sec Start 32: strace_test 32/49 Test #32: strace_test ....................... Passed 0.22 sec Start 33: drfuzz_test_empty 33/49 Test #33: drfuzz_test_empty ................. Passed 0.22 sec Start 34: drfuzz_test_mutator 34/49 Test #34: drfuzz_test_mutator ............... Passed 2.38 sec Start 35: drfuzz_test_repeat 35/49 Test #35: drfuzz_test_repeat ................***Failed Start 36: drfuzz_test_segfault 36/49 Test #36: drfuzz_test_segfault .............. Passed 0.20 sec Start 37: drfuzz_test_app_abort 37/49 Test #37: drfuzz_test_app_abort ............. Passed 0.22 sec Start 38: drfuzz_test_no_crash 38/49 Test #38: drfuzz_test_no_crash .............. Passed 0.22 sec Start 39: umbra_test_empty 39/49 Test #39: umbra_test_empty .................. Passed 0.22 sec Start 40: umbra_test_overlap 40/49 Test #40: umbra_test_overlap ................ Passed 0.23 sec Start 41: umbra_test_shadow_mem 41/49 Test #41: umbra_test_shadow_mem ............. Passed 0.30 sec Start 42: umbra_test_insert_app_to_shadow 42/49 Test #42: umbra_test_insert_app_to_shadow ... Passed 0.29 sec Start 43: umbra_test_consistency 43/49 Test #43: umbra_test_consistency ............ Passed 0.30 sec Start 44: umbra_test_allscales 44/49 Test #44: umbra_test_allscales .............. Passed 0.39 sec Start 45: drltrace 45/49 Test #45: drltrace .......................... Passed 0.35 sec Start 46: drltrace_libcalls 46/49 Test #46: drltrace_libcalls ................. Passed 0.36 sec Start 47: drltrace_symargs 47/49 Test #47: drltrace_symargs .................. Passed 0.36 sec Start 48: drltrace_libargs 48/49 Test #48: drltrace_libargs .................. Passed 0.35 sec Start 49: strace_sample 49/49 Test #49: strace_sample ..................... Passed 0.22 sec 88% tests passed, 6 tests failed out of 49

derekbruening · 2021-07-28T19:50:28Z

Hi @gregcawthorne -- wondering if you could provide a status update on where things are with the aarch64 port? It sounds like you have the slowpath working for small apps locally?

gregcawthorne · 2021-07-28T21:20:57Z

Hi yes the full slowpath port works with small apps locally.

I'd say its definitely a useful contribution, but there are of course some test cases that still fail and the fast path to do.

Greg

derekbruening · 2021-07-28T21:22:45Z

Hi yes the full slowpath port works with small apps locally.

I'd say its definitely a useful contribution, but there are of course some test cases that still fail and the fast path to do.

+1, definitely useful, and have to start somewhere. There are some key use cases of the tool on things like computer science class homeworks where working on simple apps, even if not super fast, is sufficient.

derekbruening · 2021-08-19T00:56:29Z

There is some interest in AArch64 Dr. Memory, even if only the slowpath works, for testing student homework submissions. @gregcawthorne -- would it be possible to get your code pushed upstream soon?

gregcawthorne · 2021-08-23T09:13:03Z

Hi Derek.

Are you happy with the style of me choosing different sub directories and making PRs for them one by one?

derekbruening · 2021-08-23T13:23:37Z

That’s much better than one giant PR, yes. If there are simple logical splits by functionality go with that but if by file is relatively logical we’ll take it.

…

On Mon, Aug 23, 2021 at 3:13 AM gregcawthorne ***@***.***> wrote: Hi Derek. Are you happy with the style of me choosing different sub directories and making PRs for them one by one? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2411 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRVIMQQUGNAGTNBON4QG5LT6IGKVANCNFSM47SJT7KQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

derekbruening · 2021-09-20T14:40:24Z

@gregcawthorne -- we would like to get AArch64 Dr. Memory going (slowpath only is fine since only running small apps) for a CS class for student homeworks.

derekbruening · 2021-09-21T22:47:58Z

@gregcawthorne Are you using drreg in your AArch64 port?

gregcawthorne · 2021-09-22T06:49:15Z

Hello. Yes I am making use of drreg in various places. Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Derek Bruening ***@***.***> Sent: Tuesday, September 21, 2021 11:48:08 PM To: DynamoRIO/drmemory ***@***.***> Cc: Greg Cawthorne ***@***.***>; Mention ***@***.***> Subject: Re: [DynamoRIO/drmemory] #i2016 slowpath-aarch64-port inital (#2411) @gregcawthorne<https://github.com/gregcawthorne> Are you using drreg in your AArch64 port? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARTBMK6O3KVNZU43AVKM54TUDEDSRANCNFSM47SJT7KQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

derekbruening · 2021-09-22T14:57:32Z

Yes I am making use of drreg in various places.

Does this mean you have merged in the branch https://github.com/DynamoRIO/drmemory/tree/i1795-use-drreg, or you have a completely parallel use of drreg to the x86/ARM use of the local register handling code?

…aarch64-port

gregcawthorne · 2022-08-30T02:35:15Z

Yes I am making use of drreg in various places.

Does this mean you have merged in the branch https://github.com/DynamoRIO/drmemory/tree/i1795-use-drreg, or you have a completely parallel use of drreg to the x86/ARM use of the local register handling code?

Hi, sorry I didn't get back to you on this.
I was using drreg in my own way, but I might have used https://github.com/DynamoRIO/drmemory/tree/i1795-use-drreg, for some inspiration.

I also had some very rough work on fastpath port I have sent to Yury, Assad and Al Grant. That also uses drreg quite a bit.

derekbruening · 2022-09-23T20:05:25Z

As the errors show this does not build on any platform, let alone aarch64. Looks like there is a bunch of work to get even the slowpath building and working.

derekbruening · 2022-09-23T21:19:21Z

There are a number of uses in this code of things that are missing from dynamorio. It's as though there was a private branch of dynamorio adding various features used in this drmemory branch but it was never committed. Things like:

INSTR_CREATE_lsl in umbra_64.c
OP_udf in stack.c
Implementing reg_get_value_ex()

There were past requests to please upstream local features -- it sounds like it hasn't happened and that work was lost??

+ Add missing get_unwind_registers() + Work around missing OP_udf with raw instr + Work around missing INSTR_CREATE_lsl with OP_ubfm + Work around missing reg_get_value_ex() with reg_get_value() and GPR assert + Fix ARM build breakage + Fix style violations

Fixes build warnings with gcc 12. Updates DR to 44312ad1c to fix gcc 12 issues there.

…aarch64-port

gregcawthorne closed this Jul 2, 2021

derekbruening reopened this Aug 28, 2022

derekbruening added 2 commits August 28, 2022 14:55

Merge branch 'master' of github.com:DynamoRIO/drmemory into slowpath-…

e99ca23

…aarch64-port

Add callstack check for direct call

9460a34

derekbruening added 4 commits September 24, 2022 11:18

Support gcc 12

8bcbc7d

Fixes build warnings with gcc 12. Updates DR to 44312ad1c to fix gcc 12 issues there.

Merge branch 'master' of github.com:DynamoRIO/drmemory into slowpath-…

cc56f03

…aarch64-port

Bump mac supported version b/c we did update GA CI to 11

2f81f11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#i2016 slowpath-aarch64-port inital #2411

#i2016 slowpath-aarch64-port inital #2411

gregcawthorne commented Jun 30, 2021

derekbruening commented Jul 28, 2021

gregcawthorne commented Jul 28, 2021

derekbruening commented Jul 28, 2021

derekbruening commented Aug 19, 2021

gregcawthorne commented Aug 23, 2021

derekbruening commented Aug 23, 2021 via email

derekbruening commented Sep 20, 2021

derekbruening commented Sep 21, 2021

gregcawthorne commented Sep 22, 2021 via email

derekbruening commented Sep 22, 2021

gregcawthorne commented Aug 30, 2022

derekbruening commented Sep 23, 2022

derekbruening commented Sep 23, 2022

#i2016 slowpath-aarch64-port inital #2411

Are you sure you want to change the base?

#i2016 slowpath-aarch64-port inital #2411

Conversation

gregcawthorne commented Jun 30, 2021

derekbruening commented Jul 28, 2021

gregcawthorne commented Jul 28, 2021

derekbruening commented Jul 28, 2021

derekbruening commented Aug 19, 2021

gregcawthorne commented Aug 23, 2021

derekbruening commented Aug 23, 2021 via email

derekbruening commented Sep 20, 2021

derekbruening commented Sep 21, 2021

gregcawthorne commented Sep 22, 2021 via email

derekbruening commented Sep 22, 2021

gregcawthorne commented Aug 30, 2022

derekbruening commented Sep 23, 2022

derekbruening commented Sep 23, 2022