Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Updates #8

wants to merge 8 commits into from

Conversation

mlasevich
Copy link

Mostly some fixes I added for my own use, but figure I'd share them back

  • Deploy certificate to same region as CloudFormation stack (previously seems to be hardcoded)
  • Allow Setting Log Level from CloudFormation Stack/Reduce default log level
  • Do not fail if SubjectAlternativeNames is an empty list. Support empty items
    in SubjectAlternativeNames list. (previously i got errors if SAN list was empty)

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #8 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         8    +3     
  Lines          298       344   +46     
  Branches        22        31    +9     
=========================================
+ Hits           298       344   +46     
Impacted Files Coverage Δ
certificate_validator/certificate_validator/api.py 100.00% <100.00%> (ø)
...ate_validator/certificate_validator/data_mapper.py 100.00% <100.00%> (ø)
...tificate_validator/certificate_validator/logger.py 100.00% <100.00%> (ø)
...ertificate_validator/certificate_validator/main.py 100.00% <100.00%> (ø)
...ficate_validator/certificate_validator/provider.py 100.00% <100.00%> (ø)
...icate_validator/certificate_validator/resources.py 100.00% <100.00%> (ø)
...ificate_validator/certificate_validator/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d40d5...a73c495. Read the comment docs.

@nickolashkraus
Copy link
Contributor

@mlasevich Thanks for the contribution! I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants