Implement constructor from and conversion to std::string_view. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathSpirit
added a commit
to JonathSpirit/FastEngine
that referenced
this pull request
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to get rid of various unnecessary copies in my code. E.g., data passed as
std::string_viewcan be used to directly construct an UTF-8 string without having to create a temporarystd::string. Also, it allows to pass the UTF-8 string directly to various functions that accept astd::string_view.I've tried to follow the surrounding code style (including the trailing whitespace). Feel free to let me know if aynthing should be changed (or adjust it yourself, you should have permission to push edits).