Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Telemetry Fixes #1515

Merged
merged 5 commits into from Feb 9, 2024
Merged

Open Telemetry Fixes #1515

merged 5 commits into from Feb 9, 2024

Conversation

AndersAbel
Copy link
Member

Rework the naming structure of the counters as the original names didn't follow the open telemetry conventions.

src/Telemetry/Telemetry.cs Outdated Show resolved Hide resolved
@Tornhoof
Copy link

Tornhoof commented Feb 6, 2024

It looks a lot better than before. :)

@AndersAbel AndersAbel marked this pull request as ready for review February 8, 2024 21:39
@brockallen brockallen added the bug Something isn't working label Feb 9, 2024
@brockallen brockallen added this to the 7.0.1 milestone Feb 9, 2024
@brockallen brockallen merged commit e130e8b into main Feb 9, 2024
5 checks passed
@brockallen brockallen deleted the anders/otel-fixes branch February 9, 2024 14:43
@brockallen brockallen linked an issue Feb 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry Metrics Naming
3 participants