Add ITokenCleanupService Interface #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to CleanupGrantsAsync. This is more accurate, because we are performing all cleanup tasks within this method, which might include removing consumed grants and expired device codes in addition to expired grants. This is strictly speaking a breaking change, but it a safe one to make because even though this method is public, it is not virtual. The assumption is that the only users of this class are - IdentityServer itself, which we change during the rename - Classes that derive from TokenCleanupService, which can't override this non-virtual method
josephdecock
force-pushed
the
joe/token-cleanup-interface
branch
from
ceff13f
to
0483ba5
Compare
josephdecock
force-pushed
the
joe/token-cleanup-interface
branch
from
52366fe
to
0b80a10
Compare
brockallen
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #981
Minor Breaking Changes
The rename is strictly speaking a breaking change, but it a safe one to make because even though this method is public, it is not virtual. The assumption is that the only users of this class are
Removing the IServerSideSessionsMarker is also technically a breaking change, but the marker itself is stored privately, so no derived class can ever make use of it. Customizations that previously were implemented by deriving from TokenCleanupService will need to simplify how they invoke the base constructor.
Also, the TokenCleanupHost now depends on an ITokenCleanupService interface instead of the TokenCleanupService class. Customizations of the TokenCleanupService that previously registered a class that derived from TokenCleanupService in the DI system will need to register that service as an ITokenCleanupService instead.