Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First cut of DCR #1206

Merged
merged 67 commits into from Mar 17, 2023
Merged

First cut of DCR #1206

merged 67 commits into from Mar 17, 2023

Conversation

josephdecock
Copy link
Member

@josephdecock josephdecock commented Mar 13, 2023 •
edited

First cut of the new configuration projects and dynamic client registration support.

leastprivilege and others added 30 commits February 8, 2023 17:07
@leastprivilege @josephdecock
first cut
d0884ec
@leastprivilege @josephdecock
first cut
1c84611
@leastprivilege @josephdecock
hosting
82caa66
@leastprivilege @josephdecock
add some basic validation
76ab4f5
@leastprivilege @josephdecock
move secret generation
3780684
@leastprivilege @josephdecock
added annotiations
b188442
@leastprivilege @josephdecock
some comments
59cd027
@leastprivilege @josephdecock
add more plumbing
20b4d26
@leastprivilege @josephdecock
add test client
46d7164
@leastprivilege @josephdecock
generate response
ced4c66
@leastprivilege @josephdecock
update IdM
4b34d72
@leastprivilege @josephdecock
add test client
b857e5a
@leastprivilege @josephdecock
fix sln
7e396fc
@josephdecock
Fix up solution file
938ceca 
Was weirdly necessary to get vscode/omnisharp happy
@josephdecock
Organized Configuration project
2af98d2
@josephdecock
Add EntityFramework Configuration store
94fff5a
@josephdecock
Refactor endpoint with more virtuals for extension
1aaa654
@josephdecock
Make DCR request/response models immutable
e432e00
@josephdecock
Add DCR configuration
87e90bb 
Generated secrets now can have a lifetime
@josephdecock
Add ConfigurationStore registration
7e7d521
@josephdecock
Use EF host for DCR testing
b3ec657
@josephdecock
Add a reminder todo
5d6b544
@josephdecock
Use IOptionsMonitor in DCR
8eef037
@josephdecock
Fix build of Configuration.EF
3429a07
@josephdecock
Fix service resolution in dcr endpoint
8ad84de
@josephdecock
Prevent EF host closing instantly on error
4c48c60 
This makes errors more visibile.
@josephdecock
Add additional connection strings
ece1655
@josephdecock
Resolve minor todo with xmldoc
95e3e03
@josephdecock
Validate that request scopes exist in DCR requests
6dd967a
@josephdecock
Several DCR updates
9946013 
- Fix mapping from request to response records
- Secrets that don't expire have client_secret_expires_at of 0,
as per spec
- Include client_secret_expires_at in response
- Add manual tests (dcr_tests.http)
@josephdecock josephdecock marked this pull request as draft March 15, 2023 15:12
@josephdecock josephdecock marked this pull request as ready for review March 16, 2023 19:27
@josephdecock
Copy link
Member Author

Linking to #111, but keeping issue open as there is still more to do before release.

@brockallen
Copy link
Member

So far so good. The TODOs file is a good idea to track pending work. Thanks!

@brockallen brockallen merged commit 010ffd9 into main Mar 17, 2023
@brockallen brockallen added this to the 6.3.0 milestone Mar 17, 2023
@brockallen brockallen added the enhancement New feature or request label Mar 17, 2023
@brockallen brockallen deleted the joe/dcr branch March 17, 2023 16:19
@josephdecock josephdecock mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brockallen brockallen brockallen approved these changes

@leastprivilege leastprivilege Awaiting requested review from leastprivilege

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josephdecock @brockallen @leastprivilege