Fix deb packaging path after openjdk 21 update #233
Conversation
WalkthroughThe modification in question pertains to an adjustment in the naming convention of the Debian package file within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- build/package-deb.sh (1 hunks)
Additional comments: 1
build/package-deb.sh (1)
- 21-21: Ensure that any scripts or documentation referencing the old Debian package file name are updated to reflect the new naming convention.
Verification successful
No references to the old Debian package file name pattern were found outside the modified script. This suggests that the change to the naming convention in
build/package-deb.shmight not require updates to other scripts or documentation within the project, based on the information available. However, it's recommended to manually verify this conclusion by reviewing any documentation or scripts not covered by the search pattern or located in directories not included in the search.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for references to the old package name pattern in the project. rg 'owlplug_[^ ]*_amd64.deb' --glob '!build/package-deb.sh'Length of output: 61
| --linux-package-name owlplug --linux-deb-maintainer contact@owlplug.com \ | ||
| --linux-menu-group "AudioVideo;Audio" --linux-shortcut | ||
|
|
||
| mv ./output/owlplug_$owlplugversion-1_amd64.deb ./output/OwlPlug-$owlplugversion.deb | ||
| mv ./output/owlplug_${owlplugversion}_amd64.deb ./output/OwlPlug-$owlplugversion.deb | ||
|
|
||
| ls ./output | ||
|
|
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [2-23]
Consider adding error handling for critical commands (cp, jpackage, mv) to ensure the script exits or handles errors gracefully when a command fails.
+ set -eAdd set -e at the beginning of the script to make it exit on any error.
📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [2-23]
Quote variables to prevent word splitting and globbing issues, especially important for paths and filenames that may contain spaces or special characters.
- cp ../LICENSE ./input/LICENSE
+ cp "../LICENSE" "./input/LICENSE"
- cp ../owlplug-client/target/owlplug-client-$owlplugversion.jar ./input/owlplug.jar
+ cp "../owlplug-client/target/owlplug-client-${owlplugversion}.jar" "./input/owlplug.jar"
- mv ./output/owlplug_${owlplugversion}_amd64.deb ./output/OwlPlug-$owlplugversion.deb
+ mv "./output/owlplug_${owlplugversion}_amd64.deb" "./output/OwlPlug-${owlplugversion}.deb"
Summary by CodeRabbit