Plus/color picker #2218
Open
Plus/color picker #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
| const rgba = hsvaToRgba(hsva); | ||
| const hex = hsvaToHex(hsva); | ||
|
|
||
| currentColor = { |
pointhalo
reviewed
May 7, 2024
pointhalo
reviewed
May 7, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ddc22a2:
|
pointhalo
reviewed
May 16, 2024
| this.setState({ isHandleGrabbing: false }); | ||
| }, | ||
| getDOM: ()=>this.ref.current, | ||
| onChange: (newColor)=>this.props.onChange(newColor) |
There was a problem hiding this comment.
notify。。。遵循规范统一命名。这是为了其他人不熟悉，介入代码的时候能快速搜索到所有对外的callback，onXX的命名太泛滥了，没有办法快速区分对外callback跟对内处理的函数。你看看其他组件的adapter命名。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information