Bump to IHaskell 0.10.1 so can use custom render type #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougBurke
changed the title
|
If you have a "new enough" IHaskell then - thanks to IHaskell/IHaskell#1185 - you don't need this, so I am going to close [*]. There may be some benefit to manually setting the mimetype, but let's see [*] it's a bit hard to track down what release this was added to IHaskell; it was probably 0.10.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the
CustomMimetypesupport inIHaskell0.10.1 is not sufficient (it encodes the data as a JSON string rather that a value). We're working on this in IHaskell/IHaskell#1173