Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Update expense report card.php to allow pdf preview even without thumbnail #29491

Merged
merged 5 commits into from Apr 27, 2024

Conversation

Vaadasch
Copy link
Contributor

In the event of a bug of imagick, PDF are not generating image.png and there is no link to open the PDF reader.

Changing to allow opening of PDF reader by clicking on the icon.

The issue come from tuxgasy docker image : tuxgasy/docker-dolibarr#148

In the event of a bug of imagick, PDF are not generating image.png and there is no link to open the PDF reader.

Changing to allow opening of PDF reader by clicking on the icon.
@Vaadasch
Copy link
Contributor Author

I don't see how i can simultaneously have a space following a closing bracket and no space at the end of line.

htdocs/expensereport/card.php Outdated Show resolved Hide resolved
@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Apr 27, 2024
@eldy eldy changed the title Update card.php to allow pdf preview even without thumbnail NEW Update expense report card.php to allow pdf preview even without thumbnail Apr 27, 2024
@eldy eldy merged commit 28bfbcc into Dolibarr:develop Apr 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants