FIX : Not qualified lines for reception #29473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Apr 27, 2024
| @@ -756,7 +756,7 @@ public function getStatusDispatch() | |||
| // qty wished in order supplier (origin) | |||
| foreach ($this->commandeFournisseur->lines as $origin_line) { | |||
| // exclude lines not qualified for reception | |||
| if (empty($conf->global->STOCK_SUPPORTS_SERVICES) && $origin_line->product_type > 0) { | |||
| if ((empty($conf->global->STOCK_SUPPORTS_SERVICES) && $origin_line->product_type == 1) || $origin_line->product_type > 1) { | |||
There was a problem hiding this comment.
Can yo tell me if
if ((!getDolGlobalString('STOCK_SUPPORTS_SERVICES') && $origin_line->product_type > 0) || $origin_line->product_type > 1) {
works for you ?
There was a problem hiding this comment.
Yes, it work, i've done the change
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When validating a reception based on a supplier order with one line that has product_type = 9 (a title line in my Dolibarr), my supplier order status changes to "PARTIALLY RECEIVED" when validate the reception. However, it should change to "COMPLETELY RECEIVED". This issue arises due to the check performed with the "STOCK_SUPPORTS_SERVICES" configuration.
Currently, if the "STOCK_SUPPORTS_SERVICES" configuration is disabled and the line is not a product (as indicated by the product_type), then all lines that are not products are not considered qualified.
However, if the configuration is enabled, all types of lines are considered qualified. I believe that only product and service types should be qualified.
What do you think?