FIX - Search user in where propal and order #29374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
requested changes
Apr 17, 2024
htdocs/commande/list.php
Outdated
| @@ -868,8 +868,10 @@ | |||
| $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."projet as p ON p.rowid = c.fk_projet"; | |||
| $sql .= ' LEFT JOIN '.MAIN_DB_PREFIX.'user as u ON c.fk_user_author = u.rowid'; | |||
| if ($search_user > 0) { | |||
| $sql .= ", ".MAIN_DB_PREFIX."element_contact as ec"; | |||
| $sql .= ", ".MAIN_DB_PREFIX."c_type_contact as tc"; | |||
| $sql .= " INNER JOIN ".MAIN_DB_PREFIX."element_contact as ec"; | |||
There was a problem hiding this comment.
We must abandon the use of join to make filter on data that is not part of the main table. We must instead have all the logic of the filter into the WHERE with IN (subselect)
eldy
added
the
PR to fix or conflict to solve
BB2A-Anthony
commented
Apr 18, 2024
There was a problem hiding this comment.
We must abandon the use of join to make filter on data that is not part of the main table. We must instead have all the logic of the filter into the WHERE with IN (subselect)
@eldy it's done
BB2A-Anthony
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX|Fix #[Search user in where]
[Long description]