Optimize json parsing #1465
Open
Optimize json parsing #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppearamidGuy
force-pushed
the
optimize-json
branch
from
e08934c
to
f9798f5
Compare
JSONObject constructor parses json, so calling constructor on main thread can cause lag
Micro optimizations in parsing
AppearamidGuy
force-pushed
the
optimize-json
branch
from
f9798f5
to
c8785d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some easy optimizations in json parsing
Actually I was surprised to see org.json instead of typically used Moshi, Jackson or Gson (which you actually use but only for themes). Are you interesting in migrating to one of these libraries?