Issue #71: Create logic to handle meetings creation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosRodrigo
requested changes
Feb 5, 2020
CarlosRodrigo
requested changes
Apr 8, 2020
src/services/MeetingsService.js
Outdated
Comment on lines
26
to
31
| // for (let i = 0; i < meetings.length; i++) { | ||
| // const filter = { meeting_id: meetings[i].id } | ||
| // console.log(filter) | ||
| // meetings[i]['sessions'] = await this.sessionsRepository | ||
| // .newGetSession(filter) | ||
| // } |
There was a problem hiding this comment.
Please remove commented code.
jvpessoa10
requested review from
CarlosRodrigo,
ehammo,
CGSILVA and
victorrattis
viniciusalbuquerque
requested changes
Feb 26, 2021
| } | ||
| getRoutes () { | ||
| this.app.post('/', async (req, res) => { | ||
| await this.genericRouter.execute(this.meetingsController.insertMeeting |
There was a problem hiding this comment.
This code has changed and you now need to pass a mapper into the execute function or use executeOld function (which is discouraged because we want to deprecate that)
There was a problem hiding this comment.
Same comment for all of the functions in this router
| @@ -0,0 +1,6 @@ | |||
| const Joi = require('joi') | |||
|
|
|||
| module.exports = Joi.object().keys({ | |||
There was a problem hiding this comment.
Do we need to add this teamsSchema now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.