Create the main screen with new UX/UI using DrawerNavigation #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haldny
requested review from
ehammo,
rodrigoperazzo,
ericbbraga,
acsb,
AmaroNeto,
antoniosj,
carlosolimpio,
CarlosRodrigo,
CGSILVA,
josecmj,
jvpessoa10,
lucaspasquier,
psteiger,
victorrattis and
viniciusalbuquerque
psteiger
requested changes
Jun 21, 2019
app/src/main/java/br/org/cesar/discordtime/stickysessions/app/StickySessionApplication.java
Outdated
Show resolved
Hide resolved
...main/java/br/org/cesar/discordtime/stickysessions/injectors/components/MeetingComponent.java
Show resolved
Hide resolved
app/src/main/java/br/org/cesar/discordtime/stickysessions/ui/main/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/br/org/cesar/discordtime/stickysessions/ui/main/MainActivity.kt
Show resolved
Hide resolved
app/src/main/java/br/org/cesar/discordtime/stickysessions/ui/main/MainActivity.kt
Show resolved
Hide resolved
app/src/main/java/br/org/cesar/discordtime/stickysessions/ui/main/MainActivity.kt
Show resolved
Hide resolved
app/src/main/java/br/org/cesar/discordtime/stickysessions/ui/meeting/MeetingFragment.kt
Outdated
Show resolved
Hide resolved
psteiger
requested changes
Jun 27, 2019
| @@ -44,7 +47,9 @@ class MainActivity : AppCompatActivity(), NavigationView.OnNavigationItemSelecte | |||
| } | |||
|
|
|||
| mToolbarTitle = findViewById(R.id.toolbar_title) | |||
There was a problem hiding this comment.
i meant:
mToolbarTitle = findViewById(R.id.toolbar_title).apply {
text = getString(R.string.nav_header_desc)
}
| @@ -32,5 +32,5 @@ | |||
| AuthModule.class | |||
| }) | |||
| public interface MeetingComponent { | |||
| void inject(MeetingActivity activity); | |||
| void inject(MeetingFragment activity); | |||
1-Add new kotlin class ViewNames in ui package with constants provided in ViewNames.java but in kotlin . 2-remove viewNames.java
Pull Request Test Coverage Report for Build 479
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the Drawer menu following the UX/UI design
fixes #182