Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sort function for channelSelect optional #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make sort function for channelSelect optional #87

wants to merge 2 commits into from

Conversation

DJKnaeckebrot
Copy link

No description provided.

@DJKnaeckebrot DJKnaeckebrot added the enhancement New feature or request label Dec 20, 2023
@DJKnaeckebrot
Copy link
Author

I added a parameter to the channelSelect function to opt in/out the alphabetical order that was enabled by default.

zVapor-Dev
zVapor-Dev approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@zVapor-Dev zVapor-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is tested and it works I'm fine with it

iMidnights
iMidnights approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@iMidnights iMidnights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

PlainDevelopment
PlainDevelopment approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@PlainDevelopment PlainDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree good sir

@DJKnaeckebrot
Copy link
Author

If this is tested and it works I'm fine with it

Tested with true false values and not passing the param. All works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zVapor-Dev zVapor-Dev zVapor-Dev approved these changes

@PlainDevelopment PlainDevelopment PlainDevelopment approved these changes

@iMidnights iMidnights iMidnights approved these changes

@breftejk breftejk Awaiting requested review from breftejk

@ezyhawk ezyhawk Awaiting requested review from ezyhawk

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DJKnaeckebrot @zVapor-Dev @PlainDevelopment @iMidnights