Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MWindowInterfacesLib and MWindowLib to version 1.3.1.2 #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jboinembalome
Copy link

First of all, thank you very much for your work on Edi, it is awesome!

When we clone the repository and build the solution, some errors appear because MWindowInterfacesLib and MWindowLib are not up to date in the projects that reference these packages (only the not the in each .csproj):

  • "Could not locate the assembly "MWindowInterfacesLib, Version=1.3.1.1, Culture=neutral, processorArchitecture=MSIL". Check to make sure the assembly exists on disk."

  • "Could not locate the assembly "MWindowLib, Version=1.3.1.1, Culture=neutral, processorArchitecture=MSIL". Check to make sure the assembly exists on disk. "

Therefore, I have updated these packages (which were also created by you 馃憤 ) if you are ok with that :)

@Dirkster99
Copy link
Owner

I have downloaded your solution and tried to compile it from scratch and got a failing build. I think there is a problem with the SimpleMetroWindow in MWindowLib and this could be why I never updated this because I found no time to make this work again :-( I am not sure how your PR improves the situation since the build is still failing - did you see a different set of errors before or is the list of errors below what you tried to fix?

image

@jboinembalome
Copy link
Author

Thank you for your answer! 馃槈
Did you try to build the solution on the fix_reference_packages branch?

I tried to solve the following problems that appear in the master branch:
EDI Error on master branch

When we move to the fix_package_references branch, we no longer get a compile error as we can see:
EDI Error on fix_package_reference branch

However, I also saw an automatic modification of Visual Studio 2019 that I did not commit because it seems that it changes depending on each user and on the Visual Studio version:
Edi Themes Changes on csproj

@Dirkster99
Copy link
Owner

Yes, I am getting the above errors with the fix_reference_packages branch - I think you have to do:

  • Solution Explorer > Clean Solution and
  • Solution Explorer > Build Solution
    (or either download the source to a new directory or make sure the packages directory is empty before building).

to replicate my errors. I am not completely sure about this one either :-( why it sometimes compiles and sometimes (with a fresh copy) does not - I am guessing its some detail about Nuget caching and library versioning(?).

@jboinembalome
Copy link
Author

I did the following steps on another PC:

  • Download the fix_reference_packages branch
  • Extract the archive to the Downloads folder (which gives me an Edi-fix_package_references folder)
  • Check that the "packages" folder does not exist in C:\Users{MyUsername}\Downloads\Edi-fix_package_references\Edi-fix_package_references\packages
  • Check that the ".nuget" folder does not contain an old version of MWindowLib in C:\Users{MyUsername}.nuget
  • Open the solution with Visual Studio 2022
  • Solution Explorer > Clean Solution
  • Solution Explorer > Build Solution
  • Check that the version of MWindowLib in the "packages" and ".nuget" folders is the version 1.3.1.2 after building the solution

And I still have no errors on my side

I also downloaded the master branch and reproduced the same steps to analyze the differences and for this case I have the 16 errors like you

There is also MWindowLib 1.3.1.2 in
C:\Users{MyUsername}\Downloads\Edi-fix_package_references\Edi-fix_package_references\packages and C:\Users{MyUsername}.nuget.

However, the Edi.Apps, Edi.Dialogs, Edi.Themes, Edi.SettingsView and Files projects do not find the MWindowInterfacesLib and MWindowLib dlls in Visual Studio:
Edi property in master

While in the fix_package_references branch, the behaviour seems to be different on my side:
Edi property in fix_reference_packages

I will try to do some more testing to be able to reproduce your error case 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants