Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustflags related issues #2372

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix rustflags related issues #2372

wants to merge 2 commits into from

Conversation

jkelleyrtp
Copy link
Member

Attempt a fix for:

There's a few ways we can fix this:

  • use cargo rustc directly (which doesn't cascade into dependencies)
  • use --config overrides
  • generate a .cargo/config.toml with the flags set
  • in the cargo.toml override the dev profile

I implemented the first approach before thinking about the other three. In reality not passing our own flags is probably for the best. I didn't realize cargo rustc doesn't impact dependencies so I'm not sure if our flags will actually make a difference if used that way.

The config override might be better, but I'd rather the other sources of flags be the override instead of us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant