Skip to content

Commit b265198

Browse files
committed
Using ZoneLevel Cloudflare API
1 parent aa288fc commit b265198

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

internal/providers/cloudflare.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func (p *Cloudflare) Reconcile(ctx context.Context, req reconcile.Request, ingre
112112
if errors.Is(err, store.ApplicationNotFoundError) {
113113
log.Info("Create access application")
114114

115-
app, err = p.client.CreateAccessApplication(ctx, p.zoneId, r.AccessApplication)
115+
app, err = p.client.CreateZoneLevelAccessApplication(ctx, p.zoneId, r.AccessApplication)
116116
if err != nil {
117117
log.Error(err, "Cannot create access application", "domain", r.Domain)
118118
recorder.Event(ingress, corev1.EventTypeWarning, "Error", fmt.Sprintf("Cannot create access application (%s): %s", r.Domain, err.Error()))
@@ -122,7 +122,7 @@ func (p *Cloudflare) Reconcile(ctx context.Context, req reconcile.Request, ingre
122122
recorder.Event(ingress, corev1.EventTypeNormal, "Created", fmt.Sprintf("Created Access Application %s (%s) audience tag: %s", app.Name, r.Domain, app.AUD))
123123

124124
for i, policy := range r.Policies {
125-
_, err := p.client.CreateAccessPolicy(ctx, p.zoneId, app.ID, policy)
125+
_, err := p.client.CreateZoneLevelAccessPolicy(ctx, p.zoneId, app.ID, policy)
126126
if err != nil {
127127
log.Error(err, "Cannot create access policy", "policy", policy)
128128
recorder.Event(ingress, corev1.EventTypeWarning, "Error", fmt.Sprintf("Cannot create access policy: %v: %s", policy, err.Error()))
@@ -139,7 +139,7 @@ func (p *Cloudflare) Reconcile(ctx context.Context, req reconcile.Request, ingre
139139
} else {
140140
if !r.Equal(app) { // Check if AccessApplication need update
141141
r.AccessApplication.ID = app.ID
142-
if app, err = p.client.UpdateAccessApplication(ctx, p.zoneId, r.AccessApplication); err != nil {
142+
if app, err = p.client.UpdateZoneLevelAccessApplication(ctx, p.zoneId, r.AccessApplication); err != nil {
143143
log.Error(err, "Cannot update access application")
144144
recorder.Event(ingress, corev1.EventTypeWarning, "Error", fmt.Sprintf("Cannot update access application: %s", err.Error()))
145145
return err
@@ -161,7 +161,7 @@ func (p *Cloudflare) Reconcile(ctx context.Context, req reconcile.Request, ingre
161161
if i <= length-1 {
162162
if !r.PolicyEqual(i, originPolicies[i]) {
163163
policy.ID = originPolicies[i].ID
164-
if _, err := p.client.UpdateAccessPolicy(ctx, p.zoneId, app.ID, policy); err != nil { // Update
164+
if _, err := p.client.UpdateZoneLevelAccessPolicy(ctx, p.zoneId, app.ID, policy); err != nil { // Update
165165
log.Error(err, "Cannot update access policies[%d]", i)
166166
recorder.Event(ingress, corev1.EventTypeWarning, "Error", fmt.Sprintf("Cannot update access policy[%d]: %s", i, err.Error()))
167167
return err
@@ -174,7 +174,7 @@ func (p *Cloudflare) Reconcile(ctx context.Context, req reconcile.Request, ingre
174174
continue
175175
}
176176
}
177-
if _, err := p.client.CreateAccessPolicy(ctx, p.zoneId, app.ID, policy); err != nil { // Create
177+
if _, err := p.client.CreateZoneLevelAccessPolicy(ctx, p.zoneId, app.ID, policy); err != nil { // Create
178178
log.Error(err, "Cannot create access policies[%d]", i)
179179
recorder.Event(ingress, corev1.EventTypeWarning, "Error", fmt.Sprintf("Cannot create access policy[%d]: %s", i, err.Error()))
180180
return err
@@ -188,7 +188,7 @@ func (p *Cloudflare) Reconcile(ctx context.Context, req reconcile.Request, ingre
188188
if removeRange < length {
189189
for i, policy := range originPolicies[removeRange:] {
190190
idx := length - 1 + i
191-
if err := p.client.DeleteAccessPolicy(ctx, p.zoneId, app.ID, policy.ID); err != nil { // Delete
191+
if err := p.client.DeleteZoneLevelAccessPolicy(ctx, p.zoneId, app.ID, policy.ID); err != nil { // Delete
192192
log.Error(err, "Cannot delete access policies[%d]", idx)
193193
recorder.Event(ingress, corev1.EventTypeWarning, "Error", fmt.Sprintf("Cannot delete access policy[%d]: %s", idx, err.Error()))
194194
return err
@@ -220,7 +220,7 @@ func (p *Cloudflare) Delete(ctx context.Context, req reconcile.Request, ingress
220220
log.Error(err, "Error from getApplication", "resourceName", resourceName)
221221
return err
222222
} else {
223-
return p.client.DeleteAccessApplication(ctx, p.zoneId, app.ID)
223+
return p.client.DeleteZoneLevelAccessApplication(ctx, p.zoneId, app.ID)
224224
}
225225
}
226226

@@ -250,6 +250,7 @@ func NewCloudflare(apiToken string, log logr.Logger, zoneName, clusterName strin
250250
}
251251

252252
zoneId, err := client.ZoneIDByName(zoneName)
253+
log.Info(fmt.Sprintf("Get zoneId: %s", zoneId))
253254
if nil != err {
254255
log.Error(err, "cannot find zoneId", "zoneName", zoneName)
255256
os.Exit(1)

internal/store/store.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func (s *Store) getApplications(ctx context.Context) error {
3737
s.mutex.Lock()
3838
defer s.mutex.Unlock()
3939

40-
res, _, err := s.client.AccessApplications(ctx, s.zoneId, cloudflare.PaginationOptions{})
40+
res, _, err := s.client.ZoneLevelAccessApplications(ctx, s.zoneId, cloudflare.PaginationOptions{})
4141
if err != nil {
4242
s.log.Error(err, "Cannot get access applications")
4343
return err
@@ -51,7 +51,7 @@ func (s *Store) GetPolicies(ctx context.Context, appId string) ([]cloudflare.Acc
5151
s.mutex.Lock()
5252
defer s.mutex.Unlock()
5353

54-
res, _, err := s.client.AccessPolicies(ctx, s.zoneId, appId, cloudflare.PaginationOptions{})
54+
res, _, err := s.client.ZoneLevelAccessPolicies(ctx, s.zoneId, appId, cloudflare.PaginationOptions{})
5555
if err != nil {
5656
return nil, err
5757
}

0 commit comments

Comments
 (0)