Fix: wrong activity background blurring #179
Conversation
| final float minBlurRadius = 10f; | ||
| final float step = 4f; | ||
|
|
||
| //set background, if your root layout doesn't have one | ||
| final Drawable windowBackground = getWindow().getDecorView().getBackground(); | ||
| final View windowBackground = getWindow().getDecorView(); |
There was a problem hiding this comment.
That's not what I meant :)
Please set it up like this. No need to change library's API
ViewGroup decorView = (ViewGroup) getWindow().getDecorView();
topBlurView.setupWith(decorView)
.setBlurAlgorithm(algorithm)
.setBlurRadius(radius);
bottomBlurView.setupWith(decorView)
.setBlurAlgorithm(new RenderScriptBlur(this))
.setBlurRadius(radius);There was a problem hiding this comment.
@Dimezis From your comment on setupWith
The lower amount of Views are in the root, the better for performance.
I agree with this point, so changing root view is not the thing I'm trying to do with the fix. I'm still would like to add a support for the lib's API to support getting decor background by getWindow().getDecorView() for blurring. This approach brings better performance, right?
Again, I think this logic could help https://github.com/mmin18/RealtimeBlurView/blob/master/library/src/com/github/mmin18/widget/RealtimeBlurView.java#L245-L261 🤔
There was a problem hiding this comment.
Again, I think this logic could help
If you squint your eyes, you'll see that's exactly what that library does - it draws the whole DecorView on the Canvas, and that's exactly why it works.
I'm still would like to add a support for the lib's API to support getting decor background by getWindow().getDecorView() for blurring
I'm not sure what you're trying to achieve in this PR, the bug is still there and this code essentially works the same as before - it takes the background from the DecorView. But instead of passing it directly, you pass the DecorView and take its background later.
This approach brings better performance, right?
The code in this PR performs identically to the original code.
If you're asking about the performance of drawing the whole DecorView when it's passed as a root, it is indeed slightly worse in theory, but I don't think you'll see a measurable difference.
TODO