Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong OpenGL equivalent for TEX_FORMAT_BC1_UNORM_SRGB #380

Open
code-monkey-101 opened this issue Jul 12, 2022 · 4 comments
Open

Wrong OpenGL equivalent for TEX_FORMAT_BC1_UNORM_SRGB #380

code-monkey-101 opened this issue Jul 12, 2022 · 4 comments

Comments

@code-monkey-101
Copy link

In GraphicTypes.h, GL_COMPRESSED_SRGB_S3TC_DXT1_EXT is mentioned as the OpenGL counterpart of TEX_FORMAT_BC1_UNORM_SRGB (DXGI_FORMAT_BC1_UNORM_SRGB).

I think, the correct counterpart is GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT.
@TheMostDiligent
Copy link
Contributor

The engine currently uses GL_COMPRESSED_SRGB_S3TC_DXT1_EXT for TEX_FORMAT_BC1_UNORM_SRGB.

@code-monkey-101
Copy link
Author

That will probably ignore the alpha bit.

@TheMostDiligent
Copy link
Contributor

Do you need alpha?

@code-monkey-101
Copy link
Author

No, I'm good, thanks. I just noticed this when I was googling for the right OpenGL equivalent for BC1_UNORM_SRGB for my own engine ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code-monkey-101 @TheMostDiligent