Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make window mode changeable #777

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

make window mode changeable #777

wants to merge 5 commits into from

Conversation

JackCrumpLeys
Copy link
Contributor

closes #570

I think waiting until #766 is closed so that we can do the toggle full-screen keybinding properly is a good idea.

Indy2222
Indy2222 requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I have several remarks, but nothing hard to fix.

Cargo.toml Outdated Show resolved Hide resolved
crates/conf/src/conf.rs Outdated Show resolved Hide resolved
crates/conf/src/conf.rs Outdated Show resolved Hide resolved
crates/controller/src/window.rs Show resolved Hide resolved
crates/controller/src/window.rs Outdated Show resolved Hide resolved
crates/controller/src/window.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot closed this Mar 26, 2024
@Indy2222 Indy2222 reopened this Mar 27, 2024
@github-actions github-actions bot removed the S-Stale label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Indy2222 Indy2222 Awaiting requested review from Indy2222

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
S-Stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support non-fullscreen mode
2 participants
@JackCrumpLeys @Indy2222