Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure same passwords for same random seeds #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure same passwords for same random seeds #131

wants to merge 2 commits into from

Conversation

rweisleder
Copy link
Contributor

Fixes #130

@rweisleder
Copy link
Contributor Author

It looks like it wasn't a good idea to use baseProducer here...
How should we handle this?

@mariuszs
Copy link
Member

All is fine with your change, but every use of baseProducer changes generated data after this use and now all tests need to be updated :(

@coveralls
Copy link

coveralls commented May 28, 2020 •
edited

Pull Request Test Coverage Report for Build 575

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.703%
Totals Coverage Status
Change from base Build 573: 0.01%
Covered Lines: 1323
Relevant Lines: 1397
💛 - Coveralls

@rweisleder
Copy link
Contributor Author

Okay, I updated the tests with the newly generated data. The build is now green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Same seed should produce same password for person
3 participants
@rweisleder @mariuszs @coveralls