Got sampled images working. Samplers are next #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its necessary for us to ignore the sampler as well, because otherwise we write it into the lifetime tracking of the pool. |
|
I'll see when it gets lifetime tracked then and have it be ignored at that point |
version increase behaviour, corrected some logger messages
creation for the former has some new validation
| @@ -101,35 +101,7 @@ class NBL_API2 ICPUDescriptorSet final : public IDescriptorSet<ICPUDescriptorSet | |||
| private: | |||
| static inline IDescriptor::E_CATEGORY getCategoryFromType(const IDescriptor::E_TYPE type) | |||
There was a problem hiding this comment.
I'll just remove the function all together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writing the necessary stuff so that we can have decoupled image/samplers in bindings
Testing
I changed example 07 a little bit and it runs normally. If you remove the sampler from the equation it doesn't forward any to the vk write
TODO list:
If you still provide a sampler in the DescWrite, it will be forwarded to Vulkan (the current way stuff works is that if the type's category is image and you provide samplers, they will be sent). I think this is not an issue because if the
VkDescriptorTypeof the write isVK_SAMPLED_IMAGEthe samplers of the image info are ignored. However it makes no sense to give samplers to an image info for a sampled image descriptor. If necessary I can make it generate a warning or fail