Skip to content

Commit

Permalink
Time to get serious. Upgraded version to 1.0.0 and fixed an unchecked…
Browse files Browse the repository at this point in the history
… null causing a test to fail. TODO need to add a new test to check that the disallowedworlds feature is working.
  • Loading branch information
ProgrammerDan committed Apr 24, 2017
1 parent 739ed16 commit 8815342
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pom.xml
Expand Up @@ -5,7 +5,7 @@
<groupId>com.devotedmc</groupId>
<artifactId>ExilePearl</artifactId>
<packaging>jar</packaging>
<version>0.5.9-SNAPSHOT</version>
<version>1.0.0-SNAPSHOT</version>
<name>ExilePearl</name>
<url>https://github.com/DevotedMC/ExilePearl</url>

Expand Down Expand Up @@ -124,7 +124,7 @@
<dependency>
<groupId>io.lumine.xikage</groupId>
<artifactId>MythicLib</artifactId>
<version>0.0.1-SNAPSHOT</version>
<version>1.0.1</version>
<scope>provided</scope>
</dependency>

Expand Down
Expand Up @@ -268,7 +268,7 @@ public void decayPearls() {
}

PearlHolder holder = pearl.getHolder();
if(holder.isBlock() && disallowedWorlds.contains(holder.getLocation().getWorld().getName())) {
if(holder != null && holder.isBlock() && disallowedWorlds.contains(holder.getLocation().getWorld().getName())) {
pearlApi.log("Freeing pearl for player %s because the pearl is stored in disallowed world %s.", pearl.getPlayerName(),holder.getLocation().getWorld().getName());
pearlsToFree.add(pearl);
}
Expand Down

1 comment on commit 8815342

@ProgrammerDan
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the test not failing for you? Ideally I'd have just improved the test but tl;dr....

Please sign in to comment.