Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ergonomics intro #75

Merged
merged 1 commit into from
Mar 22, 2024
Merged

add ergonomics intro #75

merged 1 commit into from
Mar 22, 2024

Conversation

mcraa
Copy link
Contributor

@mcraa mcraa commented Mar 15, 2024

  • proofread
  • i tried to use the image in the header as "/blog/folder/image.jpg" but it did not load locally is the "featuredImage" property working with full URLs only?
  • added the public folder to .gitignore , any reason it was not there before?

@marcusstigelid
Copy link
Contributor

As you can see I added some comments, mainly regarding wordings and spellings. Otherwise this looks great! Nice to see that the blog gets updated again.

@marcusstigelid
Copy link
Contributor

Regarding the public folder I am not sure why it hasn't been added before. I only noticed it now as well that a lot of files were generated and that we didn't ignore them, so it's great that you've added it.

Copy link
Member

@Dunklas Dunklas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the late review! Great post, and I love that you're bringing this topic into the organization! :)

I've left a few comments, both on spelling and regarding some sentences which I had a bit trouble reading.

And a tip for coming posts is to write one sentence per line.
It'll look the same when published, but is awesome while writing and reviewing :)
I started to do it after I stumbled over this post and have made it my default behavior everytime I write markdown :)

@mcraa
Copy link
Contributor Author

mcraa commented Mar 21, 2024

@marcusstigelid @Dunklas
I updated everything mentioned.
Good points!

Dunklas
Dunklas previously approved these changes Mar 22, 2024
Copy link
Member

@Dunklas Dunklas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Regarding the featured image - For me it works OK when setting the featured_image property to "/ergonomics/header_streches.jpg".
Could you try that?

@mcraa
Copy link
Contributor Author

mcraa commented Mar 22, 2024

Awesome! Regarding the featured image - For me it works OK when setting the featured_image property to "/ergonomics/header_streches.jpg". Could you try that?

💪 probably the problem was that I included the "/blog" prefix in the path.

@mcraa mcraa requested a review from Dunklas March 22, 2024 10:46
@mcraa mcraa merged commit f7fd7e1 into main Mar 22, 2024
1 check passed
@mcraa mcraa deleted the ergonomics-01 branch March 22, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants