fix: Change size of front page image to fit lower screen resolutions #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcusstigelid
commented
Jun 12, 2023
•
marcusstigelid
commented
- Adds new files site-header.html and index.html, which are duplicated from the theme in order to change some CSS classes
- Updates the image file with a different size and crop
- Moves and adds upon the "Welcome" text on the front page to above the title to make the posts more visible
- Adds a new file site-header.html, which is duplicated from the theme in order to change a CSS class - Updates the image file with a different size and crop - Removes the "Welcome" text on the front page to make the posts more visible
marcusstigelid
commented
Jun 12, 2023
layouts/partials/site-header.html
Outdated
| <header class="cover bg-top" style="background-image: url('{{ $featured_image }}');"> | ||
| <div class="{{ .Site.Params.cover_dimming_class | default "bg-black-60" }}"> | ||
| {{ partial "site-navigation.html" .}} | ||
| <div class="tc-l pv4 pv5-l ph3 ph4-ns"> |
There was a problem hiding this comment.
Note: This is the line that has been changed from the default theme, specifically the "pv5-l" class which by default is "pv6-l"
|
This is the effect of the changes as seen on my Macbook: Current design: New design |
gadapunkfun
reviewed
Jun 13, 2023
…ins and paddings Also sets text-align of the welcome and title text to be centered to make it look better in mobile resolutions.
|
This is how it looks now after the latest change: |
marcusstigelid
commented
Jun 13, 2023
| @@ -0,0 +1,55 @@ | |||
| {{ define "main" }} | |||
| <article class="cf ph3 ph5-l pv3 pv2-l f4 tc-l center measure-wide lh-copy {{ $.Param "text_color" | default "mid-gray" }}"> | |||
There was a problem hiding this comment.
This file has been copied from the theme and the only thing that has been changed is the "pv2-l" class which previously was "pv4-l"
There was a problem hiding this comment.
The reason for keeping the article element there is in case we want to have something in that spot in the future, in which case someone only needs to modify the classes again to make the content fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.