option to cleanup tmp folder during cleanup phase #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jussi Vatjus-Anttila <jussiva@gmail.com>
koral--
reviewed
Apr 22, 2024
Added generic ignore for stf service files and simple fool detection in case user tried to clean system folder. NOTE: "fool detection" is very simple and it's easy to round up if user really want to make harm for devices. This is still deployment configuration so it's admin who can mess up devices, who normally won't do such thing, so I think it's okay. Signed-off-by: Jussi Vatjus-Anttila <jussiva@gmail.com>
jupe
force-pushed
the
cleanup-tmp-folder
branch
from
9114113
to
29eda81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep phones stable for longer duration, e.g.
/data/local/tmpfolder seem to be needed to cleanup every now and then. This was earlier done in separate apk/tool, but simpler to do it directly bystf, so bring such functionality natively here. If folder/file removing fails, error message are written to logs. Cleanup ignorestfservice files (minicap.apk, minicap, minicap.so, minitouch, minirev).NOTE: "fool detection" is very simple and it's easy to round up if user really want to make harm for phone. Feature is still deployment configuration so it's admin who can mess up devices, who normally won't do such thing, so I think it's okay.
--cleanup-folders Whether to remove pre-defined folder during cleanup. [array] [default: []]Logs e.g.: