Move Bower dependencies to npm #510

DaniilSmirnov · 2022-04-18T19:45:05Z

Moved all bower dependencies to npm
added running tests from package.json

koral-- · 2022-04-18T19:51:57Z

Please add a sign-off, so DCO check will pass.

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

DaniilSmirnov · 2022-04-18T20:01:21Z

Sign-off added, checks passed :)

lib/cli/please.js

koral-- · 2022-04-19T10:39:44Z

@denis99999 @pcrepieux WDYT?

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

denis99999

here are additional comments to the review:

Why did you bring this PR, what is your motivation? Because even if bower is not recommended for a new front-end project, it works well and it is maintained, it is rather AngularJS which is no longer maintained and can be a problem for the evolution of the front-end .
You should regenerate properly the yarn.lock file and commit it also, like this:

// first clean your repo (node_modules, etc.)
$ rm yarn.lock
$ npm install -g yarn
$ yarn install

In local mode after the authentication step, the following warning appears in the web console, please fix it:
while running yarn install, the following warning appears, please fix it:

debian@debian:~/GITHUB/stf$ . ../stf-build.sh 17.9.0
Now using node v17.9.0 (npm v8.5.5)
yarn install v1.22.18
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "ng-file-upload > grunt-contrib-concat@0.5.1" has unmet peer dependency "grunt@>=0.4.0".
[5/5] Building fresh packages...
success Saved lockfile.
$ not-in-install && gulp build || in-install
Done in 43.48s.

while APK download using UI with an error message in a window the close button is no more present, I think this is due to your upgrade to AngularJS 1.5.11 from 1.5.0-rc2, here are the old behavior and the new one, please fix it:

lib/cli/please.js

package.json

webpack.config.js

denis99999 · 2022-04-19T11:35:49Z

@denis99999 @pcrepieux WDYT?

Look at my review on this item! This line must not be removed and the errors generated must be solved!

DaniilSmirnov · 2022-04-19T13:47:28Z

Why did you bring this PR, what is your motivation? Because even if bower is not recommended for a new front-end project, it works well and it is maintained, it is rather AngularJS which is no longer maintained and can be a problem for the evolution of the front-end .

I plan in the future (this or the next quarter of the year) to make a PR in which the angular will be replaced with something more modern, maybe React

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

package.json

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

DaniilSmirnov · 2022-04-20T14:59:37Z

Fixed in last commit

it happened after bootstrap update

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

denis99999

trying to yarn install I got this error:

debian@debian:~/GITHUB/stf$ . ../stf-build.sh 17
Now using node v17.9.0 (npm v8.5.5)
yarn install v1.22.18
error An unexpected error occurred: "Unknown token: { line: 1458, col: 1, type: 'INVALID', value: undefined } 1458:1 in /home/debian/GITHUB/stf/yarn.lock".
info If you think this is a bug, please open a bug report with the information provided in "/home/debian/GITHUB/stf/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I removed yarn.lock file and regenerated it properly by running the yarn install command, do that please and do not update manuallly this file because that is forbidden and lead to inconsistencies

After that yarn install and gulp test worked well, but trying to run STF locally I got the following exception, please fix it:

debian@debian:~/GITHUB/stf$ ./bin/stf local --public-ip 192.168.1.102
2022-04-21T09:41:41.376Z INF/util:procutil 9538 [*] Forking "/home/debian/GITHUB/stf/lib/cli migrate"
node:internal/validators:120
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:372:5)
    at validateString (node:internal/validators:120:11)
    at Object.parse (node:path:1450:5)
    at verify (/home/debian/GITHUB/stf/node_modules/please-update-dependencies/index.js:14:18)
    at module.exports (/home/debian/GITHUB/stf/node_modules/please-update-dependencies/index.js:131:8)
    at Object.<anonymous> (/home/debian/GITHUB/stf/lib/cli/please.js:2:38)
    at Module._compile (node:internal/modules/cjs/loader:1099:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/debian/GITHUB/stf/bin/stf:2:1)
    at Module._compile (node:internal/modules/cjs/loader:1099:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:975:32) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Before posting a commit on your PR, please fully test your updates, it is a prerequisite for a review whose main purpose is not to debug a PR, thanks

denis99999 · 2022-04-21T09:50:42Z

webpack.config.js

+      , alias: {
+            localforage: 'localforage/dist/localforage.js'
+          , 'socket.io': 'socket.io-client'
+          , stats: 'stats.js/src/Stats.js'
+      }


At the risk of repeating myself, add 2 spaces to align the alias section

can you make the change please

denis99999 · 2022-04-21T10:18:01Z

I plan in the future (this or the next quarter of the year) to make a PR in which the angular will be replaced with something more modern, maybe React

What feature(s) do you plan to add to STF ?

denis99999 · 2022-04-28T16:31:40Z

@DaniilSmirnov, look at PR #522 and PR DeviceFarmer/please-update-dependencies#1, they fix the remaining issue, when they will be merged, you will be able to restore the lib/cli/please.js file at his original state

…tps (DeviceFarmer#607) Signed-off-by: Energoblock <7158577+Energoblock@users.noreply.github.com> Signed-off-by: Energoblock <7158577+Energoblock@users.noreply.github.com>

Fixes DeviceFarmer#608

* Enable device market name Signed-off-by: mivashkin <mivashkin@playtika.com> Co-authored-by: mivashkin <mivashkin@playtika.com> Co-authored-by: Karol Wrótniak <karol.wrotniak@droidsonroids.pl>

Signed-off-by: Riste <rsamardjiev@playtika.com>

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.3...2.29.4) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

Update Adbkit to 3.2.3 Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

# Conflicts: # lib/units/device/resources/service.js # package.json

di.smirnov added 2 commits April 18, 2022 22:52

bower removes

6443ea4

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

version up

8f4c954

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

DaniilSmirnov force-pushed the master branch from 6aabcc5 to 8f4c954 Compare April 18, 2022 19:53

koral-- reviewed Apr 19, 2022

View reviewed changes

lib/cli/please.js Outdated Show resolved Hide resolved

koral-- requested review from denis99999 and pcrepieux April 19, 2022 10:39

koral-- mentioned this pull request Apr 19, 2022

upgrade node to latest version v17.9.0 #500

Merged

remove commented line

c7c7f9c

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

DaniilSmirnov force-pushed the master branch from 0269732 to c7c7f9c Compare April 19, 2022 10:53

denis99999 reviewed Apr 19, 2022

View reviewed changes

review fixes part 1

7693003

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

DaniilSmirnov force-pushed the master branch from 435e5f2 to 7693003 Compare April 19, 2022 14:02

denis99999 reviewed Apr 19, 2022

View reviewed changes

package.json Show resolved Hide resolved

di.smirnov added 3 commits April 19, 2022 21:48

move packages to res

166c57d

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

fix eslint

da12151

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

fix error alert

7151d77

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

workaround for bug in lib

b7fe079

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

DaniilSmirnov requested a review from denis99999 April 20, 2022 15:37

Merge branch 'master' into master

8ef6fb0

denis99999 reviewed Apr 21, 2022

View reviewed changes

This was referenced Apr 27, 2022

stf:latest (3.6.2) breaks provider - adb.createClient is not a function #518

Closed

use the fork of the please-update-dependencies package #522

Merged

Energoblock and others added 30 commits October 31, 2022 17:09

Fixing the link to get the package swagger-node-runner from ssh to ht…

e7e0d3b

…tps (DeviceFarmer#607) Signed-off-by: Energoblock <7158577+Energoblock@users.noreply.github.com> Signed-off-by: Energoblock <7158577+Energoblock@users.noreply.github.com>

Update rethinkdb to 2.4.2 in docker compose sample (DeviceFarmer#611)

dd8c186

Fixes DeviceFarmer#608

Enable device market name (DeviceFarmer#601)

24c944d

* Enable device market name Signed-off-by: mivashkin <mivashkin@playtika.com> Co-authored-by: mivashkin <mivashkin@playtika.com> Co-authored-by: Karol Wrótniak <karol.wrotniak@droidsonroids.pl>

move off screen password autofill (DeviceFarmer#610)

f168b45

Signed-off-by: Riste <rsamardjiev@playtika.com>

Update device-db to 1.3.0 (DeviceFarmer#619)

a146768

bower removes

856d5f0

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

version up

b75ebfc

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

review fixes part 1

ffbe511

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

move packages to res

ec994aa

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

fix eslint

587aa26

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

fix error alert

0080e90

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

workaround for bug in lib

f3d61d6

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

update master

d012aab

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

bower removes

ec6e024

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

move packages to res

8574a17

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

Fix adbkit API invocations (DeviceFarmer#524)

514c051

Update Adbkit to 3.2.3 Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

bower removes

bfe9686

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

move packages to res

62bb46a

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

update master

664bc2f

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

bower removes

6a38c94

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

move packages to res

35c22fe

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

update master

20007b5

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

bower removes

899df36

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

move packages to res

41255df

Signed-off-by: di.smirnov <di.smirnov@corp.vk.com>

update master

2c17f46

review fix

61dbe1e

Merge remote-tracking branch 'origin/master'

9e88ff0

# Conflicts: # lib/units/device/resources/service.js # package.json

resolve confilcts

51c0447

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Bower dependencies to npm #510

Move Bower dependencies to npm #510

DaniilSmirnov commented Apr 18, 2022

koral-- commented Apr 18, 2022

DaniilSmirnov commented Apr 18, 2022

koral-- commented Apr 19, 2022

denis99999 left a comment •

edited

denis99999 commented Apr 19, 2022

DaniilSmirnov commented Apr 19, 2022

DaniilSmirnov commented Apr 20, 2022 •

edited

denis99999 left a comment

denis99999 Apr 21, 2022

denis99999 May 11, 2022

denis99999 commented Apr 21, 2022

denis99999 commented Apr 28, 2022

Move Bower dependencies to npm #510

Are you sure you want to change the base?

Move Bower dependencies to npm #510

Conversation

DaniilSmirnov commented Apr 18, 2022

koral-- commented Apr 18, 2022

DaniilSmirnov commented Apr 18, 2022

koral-- commented Apr 19, 2022

denis99999 left a comment • edited

Choose a reason for hiding this comment

denis99999 commented Apr 19, 2022

DaniilSmirnov commented Apr 19, 2022

DaniilSmirnov commented Apr 20, 2022 • edited

denis99999 left a comment

Choose a reason for hiding this comment

denis99999 Apr 21, 2022

Choose a reason for hiding this comment

denis99999 May 11, 2022

Choose a reason for hiding this comment

denis99999 commented Apr 21, 2022

denis99999 commented Apr 28, 2022

denis99999 left a comment •

edited

DaniilSmirnov commented Apr 20, 2022 •

edited