Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect RFC-0097 #464

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Respect RFC-0097 #464

wants to merge 3 commits into from

Conversation

Hoverbear
Copy link
Contributor

Description

Sets the default /nix/store permissions to 735 as per https://github.com/NixOS/rfcs/blob/master/rfcs/0097-no-read-store-dir.md.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear requested a review from cole-h May 12, 2023 19:16
@Hoverbear Hoverbear self-assigned this May 12, 2023
@Hoverbear Hoverbear added this to the 0.8.1 milestone May 12, 2023
cole-h
cole-h reviewed May 12, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is working properly -- stat /nix/store shows it's still 1775 on my test VM:
image

@cole-h cole-h added the blocked The PR is blocked by something label May 17, 2023
@cole-h cole-h marked this pull request as draft May 17, 2023 15:55
@cole-h
Copy link
Member

cole-h commented May 17, 2023

This is blocked on Nix itself implementing RFC 97 (https://github.com/NixOS/nix/blob/f8a6a9e47314acebea2d72c0ec195360eb58bbec/src/libstore/local-store.cc#L214, https://github.com/NixOS/nix/blob/f8a6a9e47314acebea2d72c0ec195360eb58bbec/src/libstore/local-store.cc#L227).

@Hoverbear Hoverbear removed this from the 0.9.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Hoverbear Hoverbear

Labels
blocked The PR is blocked by something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hoverbear @cole-h