-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for DIMCustomSymbols #9116
base: master
Are you sure you want to change the base?
Conversation
Okay, so I've recreated the font using the Private Use Plane 15 but have had a few issues trying to make this work. Firstly, the font converter we are using (@hayes0724/web-font-converter) can convert fonts using the higher PUA-A (U+F0000 - U+FFFFD) but it moves them back into the BMP (U+E000 - U+F8FF) area when it does. So all of our code points generated before the conversion look right but none of the glyphs show up because those aren't the code points being used any more.
Edit: Spoke to soon about the hashtags, fix was easier than expected once I found the relevant files. If the PUA-A plane can't be made to work, one option could be to start our code points at the end of the BMP area and expand backwards to give the Destiny Keys as much space as possible. There is more than enough room for both sets of glyphs in that range and with the new strand additions it looks like Bungie is finally appending them to the end in a reasonable way so hopefully there wouldn't be any future conflicts. |
Thanks for the updates. I think there are still some concerns about how we keep the font stable as symbols are added/removed, and whether we'd want to shift to more of a Slack/Discord-style |
Opened a PR for just the emojis #9254. |
As for Slack-style symbols, from what I can think of, the pros and cons would be: Slack-style
Custom Font
Personally, I like the idea having alt text for the symbols and when editing notes, but, I would prefer it to match Bungie's and use the rich-text replacement system. e.g. [solar] not :solar: Though, this is applicable to either style I think. |
Not sure if d2-additional-info just rarely gets reviewed or something, but, I've made an update to d2-additional-info#441 awhile ago that includes the font generation from the .SVG files that will automate adding new glyphs while maintaining the codepoints, however, I could still use some feedback and assistance to make sure I am correctly including the new node module it needs in the PR. |
8c268d0
to
baf51a1
Compare
baf51a1
to
f930a75
Compare
Coincides with Adding DIMCustomSymbols #441
Revised and cleaned up to properly use data generated with d2-additional-info.
Custom glyphs now generate their own Enums file.
I expanded the Tables list to support more API data and extended Objective functionality to include non-richtext entries so there will be less manualTranslations work.
Marked as draft until I have recreated the font file using a different Private Use Area or a SVG-to-font generator is created, so that users can't start using these before the code points change.