Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Item Loadout Count in Loadout Optimizer #10383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bjacobel
Copy link
Contributor

@bjacobel bjacobel commented May 1, 2024

Refs: #10025

Specifically the first referenced piece of feedback from Discord:

Show loadout counts beneath generated items in loadout optimizer

https://discord.com/channels/316217202766512130/1061257003420360704/1061257003420360704

This brings the loadout icon and count from the triage popup to show underneath energy capacity in the loadout organizer.

image

Open to design changes here - I'm still not perfectly happy with it. Discussed here in Discord.

@bhollis
Copy link
Contributor

bhollis commented May 8, 2024

Thanks for working on this! They look good. I wanted to think through the feature a bit though, because especially in the LO rows, space is at a premium and they're already showing a lot of info. I've also been stuck on a redesign of these for a while that could remove a lot of info...

While I understand the original request from https://discord.com/channels/316217202766512130/1147798597539213343, I'm not 100% sure this fits with the theme of loadout optimizer, which is about making the best possible sets. This is helping to optimize for a different metric which is "maximum reuse of items", but that doesn't really matter when you have some new armor that's better than the old armor, even if the old armor is used in a lot of existing loadouts. And while it can be annoying to click into the item popup to check for these, it is there already.

BTW, if these two features were in two PRs, it'd be easier to merge them independently, rather than blocking both on discussion about one.

@bjacobel
Copy link
Contributor Author

bjacobel commented May 9, 2024

That all makes sense. This is hard to fit into the current design of the loadout optimizer, and I don't want to make any other work there more difficult by adding another feature now that needs to be accounted for in a redesign. Your choice if you'd like to leave this PR open medium-term or close it for now - I'll open another PR up for the inloadoutcount search filter feature and rebase that out of this PR.

@bjacobel bjacobel changed the title In Loadout Count Show Item Loadout Count in Loadout Organizer May 9, 2024
@bhollis bhollis changed the title Show Item Loadout Count in Loadout Organizer Show Item Loadout Count in Loadout Optimizer May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants