Paper-only client_options tag.
#2619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heypr
commented
May 8, 2024
heypr
commented
- Requested by Gravitation on Discord.
tal5
reviewed
May 9, 2024
Comment on lines
39
to
40
| // Returns the player's client options. | ||
| // The allow_server_listings & text_filtering_enabled options are only available in MC 1.19+. |
There was a problem hiding this comment.
Needs to document what exactly does the map have - but are we sure a map is the best way to implement this? it'll probably mostly be used as <[player].client_options.get[option]>, might make more sense to do <[player].client_option[<option>]> or something?
| // - 'chat_colors_enabled' (ElementTag(Boolean)): whether the player has chat colors enabled. | ||
| // - 'chat_visibility' (ElementTag(String)): the player's current chat visibility option. Possible output values are: FULL, SYSTEM, HIDDEN, and UNKNOWN. | ||
| // - 'locale' (ElementTag(String)): the player's current locale. | ||
| // - 'main_hand' (ElementTag(String)): the player's main hand, either LEFT or RIGHT. |
There was a problem hiding this comment.
ElementTag(String) does not exist
mcmonkey4eva
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.