Adds the PlayerArmorStandManipulate event
#2601
Conversation
...main/java/com/denizenscript/denizen/events/player/PlayerArmorStandManipulateScriptEvent.java
Show resolved
Hide resolved
| if (!path.tryObjectSwitch("player_item", playerItem)) { | ||
| return false; | ||
| } | ||
| if (!path.tryObjectSwitch("slot", new ElementTag(event.getSlot()))) { |
There was a problem hiding this comment.
Enum switches should use runGenericSwitchCheck (also applies to the other one)
| // | ||
| // @Switch armor_stand_item:<item> to only process the event if the armor stand is holding a specific item. | ||
| // @Switch hand:<hand> to only process the event if the player is using a specific hand to interact with the armor stand. Available only on MC versions 1.19+. | ||
| // @Switch player_item:<item> to only process the event if the player is holding a specific item. |
There was a problem hiding this comment.
Switch meta should specify it's a matcher, e.g. something like player_item:<item> to only process the event if the item held by the player matches the specified item matcher.
| // @Switch slot:<slot> to only process the event if the armor stand's item slot that was interacted with is the specified slot. | ||
| // | ||
| // @Context | ||
| // <context.armor_stand_item> returns the ItemTag held by the armor stand. |
There was a problem hiding this comment.
Should verify what this item actually is and update meta accordingly, see discussion on Discord
|
|
||
| @Override | ||
| public boolean matches(ScriptPath path) { | ||
| if (!runInCheck(path, event.getPlayer().getLocation())) { |
There was a problem hiding this comment.
Probably makes more sense to use the armor stand's location here? the in: switch with this event would probably be used for stuff like protecting armor stands in a specific area
| if (!path.tryObjectSwitch("player_item", playerItem)) { | ||
| return false; | ||
| } | ||
| if (!runGenericSwitchCheck(path,"slot", event.getSlot().name())) { |
There was a problem hiding this comment.
Missing space between args (on the other runGenericSwitchCheck as well)
|
|
||
| public PlayerArmorStandManipulateScriptEvent() { | ||
| registerCouldMatcher("player edits armor stand"); | ||
| registerSwitches("armor_stand_item", "hand", "player_item", "slot"); |
There was a problem hiding this comment.
Should have some switch/matcher for the armor stand itself as well
|
|
||
| // <--[event] | ||
| // @Events | ||
| // player edits <'armor_stand'> |
There was a problem hiding this comment.
this event line is extremely liable to conflict with events, currently it conflicts with 1 (player edits book)
|
LGTM, although |
|
Maybe |
PlayerArmorStandManipulateevent #2600