Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Resolve "imod.visualize.cross_section does not support quasi 3D layering" #690

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Draft: Resolve "imod.visualize.cross_section does not support quasi 3D layering" #690

wants to merge 4 commits into from

Conversation

Manangka
Copy link
Collaborator

In GitLab by @jdelsman on Feb 9, 2023, 18:06

Closes #329

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Feb 9, 2023, 18:09

added 1 commit

  • 03053b9 - fix for quasi 3d layering

Compare with previous version

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Feb 9, 2023, 18:09

An initial fix for issue #329. Works for my use-case, but haven't thoroughly tested...

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Feb 9, 2023, 18:10

requested review from @JoerivanEngelen

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Feb 9, 2023, 18:10

requested review from @Huite

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Feb 9, 2023, 18:10

removed review request for @JoerivanEngelen

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Feb 9, 2023, 18:16

added 1 commit

  • 107c942 - reverted inclusion of colorbar

Compare with previous version

@Manangka
Copy link
Collaborator Author

In GitLab by @JoerivanEngelen on Feb 17, 2023, 10:28

I think this merge request is also related to https://gitlab.com/deltares/imod/imod-python/-/issues/175, right?

@Manangka
Copy link
Collaborator Author

In GitLab by @JoerivanEngelen on May 26, 2023, 10:22

added 73 commits

Compare with previous version

@Manangka
Copy link
Collaborator Author

In GitLab by @JoerivanEngelen on May 26, 2023, 10:30

Thanks for the fixes, these seem to fix some obvious mistakes in the code. I see our tests currently cover the visualization very poorly; so it is hard to tell if these fixes actually work.
Asking you to add tests will be quite the burden to you, as the test bench is not in a good shape for the visualization module anyway.

I think we first need to add some unit tests covering of _meshcoords, to see if this actually does the right thing.

For now, I at least rebased this branch, to make sure it is still up to date.

@Manangka
Copy link
Collaborator Author

In GitLab by @jdelsman on Sep 22, 2023, 16:20

added 3 commits

Compare with previous version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imod.visualize.cross_section does not support quasi 3D layering
1 participant
@Manangka