Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex classification #45

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Flex classification #45

wants to merge 2 commits into from

Conversation

laurenebouaziz
Copy link
Contributor

hi, I added a workflow to calculate the percentages of each hydrological response unit based on hand and slope, which is data needed to run the flextopo model.
@hboisgon , could you have a look at the implementation (no rush, after your holidays is fine!)?

@laurenebouaziz
Copy link
Contributor Author

I think this should probably be done in a separate wflow flextopo class?

@hboisgon
Copy link
Contributor

hboisgon commented Aug 6, 2021

Hi Laurène, nice that you are strating to work on flextopo!
I think it is better to define a new model for wflow_flextopo, wflow is actually more wflow_sbm. Especially if you need different input for wflow_flextopo.

You can have a look at wflow_sediment for an example. In principle you can define wflow_flextopo as a subclass of WflowModel instead of the model API. In that case every function that is completely the same can still be called without needing to re-define it (exemple setup_basemaps for wflow_sediments). If some functions are a little different, you can first call the main super function and then afterwards do flextopo specific operations (exemple setup_lakes). Or even re-use the super function but with slightly different function parameters (exemple setup_lulcmaps or setup_gauges).

Hope this helps you get nicely started :)

@laurenebouaziz
Copy link
Contributor Author

thanks @hboisgon this will definitely be useful to get started :) !

@JoostBuitink JoostBuitink marked this pull request as draft January 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants