New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Catalogs #921
Merged
Merged
Refactor Catalogs #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tjalling-dejong
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some typos, other than that LGTM
Co-authored-by: Tjalling-dejong <93266159+Tjalling-dejong@users.noreply.github.com>
Tjalling-dejong
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t into refactor-catalogs-take-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #844
Explanation
Another attempt at merging #849. See that PR for more information, but I'll detail the changes I've also made here:
github.com
domain instead ofraw.githubusercontent.com
domain meaning that HTML files were retrieved instead of the registry files themselves causing errors in pooch.Checklist
main
Additional Notes (optional)
As we saw during the last time this got merged, it is really difficult to see what the docs will do once it's merged. As such, I don't think there's much we can do now, but just get the PR through review, merge it again, and then deal with any issues that come up then. I'll be available to diagnose and fix any issues once this gets merged.