Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equal ratio allocation objective take 2 #1386

Merged
merged 32 commits into from May 23, 2024
Merged

Equal ratio allocation objective take 2 #1386

merged 32 commits into from May 23, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Merge equal_allocation_objective again after #1385, after fixing #1383.

@SouthEndMusic SouthEndMusic changed the title Equal ratio allocation objective Equal ratio allocation objective take 2 Apr 15, 2024
@SouthEndMusic SouthEndMusic marked this pull request as draft April 15, 2024 09:37
@SouthEndMusic SouthEndMusic marked this pull request as ready for review April 22, 2024 16:31
@SouthEndMusic SouthEndMusic requested a review from visr April 22, 2024 16:37
visr
visr reviewed Apr 22, 2024
View reviewed changes
core/src/allocation_init.jl Outdated Show resolved Hide resolved
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Apr 23, 2024 •
edited

The FlowBoundary node was not marked as flow direction constraining, which lead to unconstrained allocation flow into FlowBoundary nodes in several models. Hopefully this brings us back to deterministic behavior, at least where it matters.

@SouthEndMusic SouthEndMusic requested a review from visr April 23, 2024 12:21
@SouthEndMusic SouthEndMusic marked this pull request as draft April 24, 2024 10:38
@SouthEndMusic SouthEndMusic mentioned this pull request May 21, 2024
Closed
@SouthEndMusic SouthEndMusic marked this pull request as ready for review May 23, 2024 09:32
@SouthEndMusic SouthEndMusic merged commit 1386ced into main May 23, 2024
24 checks passed
@SouthEndMusic SouthEndMusic deleted the equal_ratio_allocation_objective branch May 23, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SouthEndMusic @visr