Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiGHS dimension mismatch #1383

Open
visr opened this issue Apr 15, 2024 · 4 comments
Open

HiGHS dimension mismatch #1383

visr opened this issue Apr 15, 2024 · 4 comments
Labels
allocation Allocation layer dependencies Pull requests that update a dependency file

Comments

@visr
Copy link
Member

visr commented Apr 15, 2024

HiGHS prints "dimension mismatch". @SouthEndMusic ran into this before. It comes from inside HiGHS:

https://github.com/ERGO-Code/HiGHS/blob/13363c9f1252b015cf6527132eb9cf8f4b5bf020/src/qpsolver/factor.hpp#L181

But it doesn't seem to be a failure. @SouthEndMusic is this related to #1366?

@visr visr changed the title Allocation test failures HiGHS dimension mismatch Apr 15, 2024
@visr visr added dependencies Pull requests that update a dependency file bug Indicates an unexpected problem or unintended behavior allocation Allocation layer and removed bug Indicates an unexpected problem or unintended behavior labels Apr 15, 2024
@SouthEndMusic
Copy link
Collaborator

The dimension mismatch thing doesn't fail any tests right? And indeed the failing test just needs an increased tolerance. I saw that on main the Julia tests fail on Windows but not on Linux

@visr
Copy link
Member Author

visr commented Apr 15, 2024

Yeah you are right, I already updated this issue to split out the error that should be fixed by #1384 and make this just about the dimension mismatch print statement.

@SouthEndMusic
Copy link
Collaborator

But it doesn't seem to be a failure. @SouthEndMusic is this related to #1366?

Maybe there's still some redundant things left in the problems after removing most of the code for absolute value calculations, I'll have a look.

@visr
Copy link
Member Author

visr commented Apr 15, 2024

Possibly related, here something seems to be stuck in "Allocation with main network optimization problem".

  Worker 4531:  [4531] signal (15): Terminated
in expression starting at none:1


No Captured Logs for test item "Allocation with main network optimization problem" at test/allocation_test.jl:194 on worker 4528
┌ Error: Worker(pid=4528, terminated=true, termsignal=9) timed out running test item "Allocation with main network optimization problem" after 1800 seconds. Recording test error.
└ @ ReTestItems ~/.julia/packages/ReTestItems/ELM7z/src/ReTestItems.jl:557

From https://github.com/Deltares/Ribasim/actions/runs/8685702994/job/23815699761?pr=1384#step:6:515

visr added a commit that referenced this issue Apr 15, 2024
This reverts commit 19139f1,
#1366.

It introduced some non-deterministic failures, that would be best to
investigate outside of main.

See #1383. To land this again
we should also include #1384,
which addressed one of the failures.
SouthEndMusic added a commit that referenced this issue May 23, 2024
Merge `equal_allocation_objective` again after
#1385, after fixing
#1383.

---------

Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation Allocation layer dependencies Pull requests that update a dependency file
Projects
Status: To do
Development

No branches or pull requests

2 participants