GRIDEDIT-946: Add script for retreiving the version from the nuspec config #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-el-sayed
changed the title
priscavdsluis
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Looks good! In issue GRIDEDIT-946 I see that it should or could be used for MeshKernelNet as well as the GEP. @ScottWillcox mentioned that we might also consider it for other D-HYDRO products and I agree with that.
It might be good to move this script to the D-HYDRO-Automation-Scripts repository, so that it can be easily reused.
|
@priscavdsluis This is the plan. The script was included here for simplicity. There's nothing to merge here. Once the script is merged to D-HYDRO-Automation-Scripts, Meshkernel, MeshKernelNET and GridEditorPlugin configurations in TeamCity must be adapted. I will close this PR. and create a new one in D-HYDRO-Automation-Scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.