Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dimr_config for parallel run is incorrect #623

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Bug: dimr_config for parallel run is incorrect #623

wants to merge 37 commits into from

Conversation

MRVermeulenDeltares
Copy link
Contributor

No description provided.

@MRVermeulenDeltares MRVermeulenDeltares linked an issue Apr 17, 2024 that may be closed by this pull request
dimr_config for parallel run is incorrect #562
Open
@tim-vd-aardweg
Copy link
Contributor

Fixes: #562

@tim-vd-aardweg
Copy link
Contributor

Have a look at the SonarCloud issue please! :)

tim-vd-aardweg
tim-vd-aardweg reviewed Apr 22, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed Apr 22, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
MRVermeulenDeltares and others added 16 commits April 25, 2024 12:31
@MRVermeulenDeltares
bug: update that input of zero throws exception and input of one adds…
46792cd 
… no process to the output file(#562)
@MRVermeulenDeltares
bug: implement newly discussed requirements and add tests. (#562)
07bb8e8
@MRVermeulenDeltares
autoformat: isort & black
a03c692
@MRVermeulenDeltares
bug: move tests to testclass.(#562)
0549e32
@MRVermeulenDeltares
autoformat: isort & black
fbb37c0
@MRVermeulenDeltares
bug: resolve codesmell.(#562)
3879a20
@MRVermeulenDeltares
bug: Refactor tests. (#562)
cc0d93e
@MRVermeulenDeltares
autoformat: isort & black
9c99373
@MRVermeulenDeltares
bug: add multiple fmcomponent save test (#562)
61d50fa
@MRVermeulenDeltares
bug: Refactor dimr _save method (#562)
8f24b09
@MRVermeulenDeltares
autoformat: isort & black
a45cb2f
@MRVermeulenDeltares
bug: add support for reading process with semicolon, e.g. 0:4, assumi…
a05fc37 
…ng this is the same as 0 1 2 3 4 (#562)
@MRVermeulenDeltares
autoformat: isort & black
35adfcf
@MRVermeulenDeltares
bug: resolve codesmells, make validation alike (#562)
e72c5ea
@MRVermeulenDeltares
autoformat: isort & black
35f068a
@MRVermeulenDeltares
bug: update semicolon process and add tests (#562)
b0ab381
tim-vd-aardweg
tim-vd-aardweg reviewed May 2, 2024
View reviewed changes
hydrolib/core/dimr/models.py Show resolved Hide resolved
hydrolib/core/dimr/models.py Outdated Show resolved Hide resolved
hydrolib/core/dimr/models.py Outdated Show resolved Hide resolved
hydrolib/core/dimr/models.py Outdated Show resolved Hide resolved
hydrolib/core/dimr/models.py Outdated Show resolved Hide resolved
hydrolib/core/dimr/models.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
tim-vd-aardweg
tim-vd-aardweg reviewed May 3, 2024
View reviewed changes
tests/test_model.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-vd-aardweg tim-vd-aardweg tim-vd-aardweg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dimr_config for parallel run is incorrect
2 participants
@MRVermeulenDeltares @tim-vd-aardweg