554: Requested changes for hydrologic #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
evetion
reviewed
May 8, 2024
| @@ -166,7 +167,7 @@ class Comments(INIBasedModel.Comments): | |||
| levels: Optional[List[float]] | |||
| numlocations: Optional[NonNegativeInt] = Field(0, alias="numLocations") | |||
| chainage: Optional[List[float]] | |||
| frictionvalues: Optional[List[float]] = Field( | |||
| frictionvalues: Optional[List[List[float]]] = Field( | |||
| alias="frictionValues" | |||
| ) # TODO: turn this into List[List[float]], see issue #143. | |||
evetion
reviewed
May 8, 2024
| @@ -243,7 +243,7 @@ class Comments(CrossSectionDefinition.Comments): | |||
| type: Literal["rectangle"] = Field("rectangle") | |||
| width: float | |||
| height: float | |||
| closed: bool = Field(True) | |||
| closed: str = Field("no") | |||
There was a problem hiding this comment.
Changing the type and inverting the default value is quite breaking. I'm not sure what the question was, but this might be solved by a custom reader/writer (or flag type) that translates the boolean into yes/no strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.