Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: include tests #39

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -13,7 +13,7 @@ install:
- pip install -e .[dev]

script:
- pytest --cov loguru/
- pytest --cov

after_success:
- codecov --flags "py${TRAVIS_PYTHON_VERSION//./}"
Expand Down
2 changes: 0 additions & 2 deletions tests/exceptions/enqueue_with_others_handlers.py
Expand Up @@ -4,8 +4,6 @@

def check_tb_sink(message):
exception = message.record["exception"]
if exception is None:
return
assert exception.traceback is not None


Expand Down
4 changes: 2 additions & 2 deletions tests/exceptions/not_enough_arguments.py
Expand Up @@ -7,11 +7,11 @@

@logger.catch
def decorated(x, y, z):
pass
raise NotImplementedError


def not_decorated(x, y, z):
pass
raise NotImplementedError


decorated(1)
Expand Down
4 changes: 2 additions & 2 deletions tests/exceptions/too_many_arguments.py
Expand Up @@ -7,11 +7,11 @@

@logger.catch
def decorated():
pass
raise NotImplementedError


def not_decorated():
pass
raise NotImplementedError


decorated(1)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_add_options.py
Expand Up @@ -363,7 +363,7 @@ def test_disabled_logger_in_sink(sink_with_logger):

def test_invalid_function_kwargs():
def function(message, a="Y"):
pass
raise NotImplementedError

logger.add(function, b="X", catch=False)
with pytest.raises(TypeError):
Expand All @@ -384,7 +384,7 @@ def __init__(self):
self.out = ""

def write(self, m):
pass
raise NotImplementedError

writer = Writer()
logger.add(writer, format="{message}", kw1="1", kw2="2", catch=False)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_exceptions_formatting.py
Expand Up @@ -21,7 +21,7 @@ def normalize(formatted_exception):
return formatted_exception


def generate(output, outpath):
def generate(output, outpath): # pragma: no cover
"""Generate new output file if exception formatting is updated"""
with open(outpath, "w") as file:
file.write(output)
Expand Down
3 changes: 1 addition & 2 deletions tests/test_threading.py
Expand Up @@ -11,8 +11,7 @@ def __init__(self, sleep_time):
self.stopped = False

def write(self, message):
if self.stopped:
raise RuntimeError("Can't write on stopped sink")
assert not self.stopped

length = len(message)
self.written += message[:length]
Expand Down
8 changes: 8 additions & 0 deletions tox.ini
@@ -0,0 +1,8 @@
[coverage:run]
source = .

[coverage:report]
include = loguru/*, tests/*
exclude_lines =
\#\s*pragma: no cover
^\s*raise NotImplementedError\b