Mohamed particles #252
Open
Mohamed particles #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done in Update_Boundary_Condition.f90.
it was calculated in Update_Boundary_Condition.
after zeta and F22 equations. This solved the problem that occurs otherwise. It is still important find out what is really happening.
Pointer for grid was missing and grid % vol causing an error.
"Problem with Source_T2 subroutine DelNov#128" reported by Muhamed. It was caused by missing t2 and p_t2 in heat_transfer expressions, when turbulence_model .eq. HYBRID_LES_RANS.
…Nov#128" reported by Muhamed. It was caused by missing t2 and p_t2 in heat_transfer expressions, when turbulence_model .eq. HYBRID_LES_RANS. (a minor fix to the previous commit)
Tests/Hybrid_Les_Rans/Channel_Re_Tau_2000/Stretched_Mesh/
…nd_improved_test_script Fix for hybrid t2 model and improved test script
Process/Turbulence/Allocate.f90 function did not have allocation block for the first moments statistics (u % mean, v % mean,w % mean, p % mean).
statistics in RSM models causes a crash
prevent unphysical values of u_plus.
prevent unphysical values of u_plus.
prevent unphysical values of u_plus.
prevent unphysical values of u_plus. Bug in rough_wall section is corrected.
prevent unphysical values of u_plus. EBF used in old definition of blending function is deleted.
prevent unphysical values of u_plus. EBF used in old definition of blending function is deleted.
time scale far from the wall which is not supposed to happened. 0.6 value was influencing rough wall results as well as channel flow with very high Reynolds number. The motivation for adopting 0.6 was in improving Nusselt number in impinging jets. However, theoretical number of this coefficient is around 1.
Some improvements for rough walls model and one bug corrected
In the issue DelNov#133 Bojan fairly noticed that save_exit_now test case behaved somehow incorrectly. In particular, string "save_exit_now_test was successful" has never appeared. It turned out that test relied on the output in stdout rather than in $LOG_FILE It is fixed now. Moreover, scenario which this test case reproduce is now more intricate and accurate than before.
removed in rough wall part as newly introduced limiter in z_o is sufficient.
z_o to be zero in Roughness_Coefficient.f90.
Updated test_build.sh: process_save_exit_now_test
instabilities if massive separation occures and small y_plus is present in domain.
instabilities if massive separation occures and small y_plus is present in domain.
instabilities if massive separation occures and small y_plus is present in domain.
instabilities if massive separation occures and small y_plus is present in domain.
instabilities if massive separation occures and small y_plus is present in domain.
instabilities if massive separation occures and small y_plus is present in domain.
One bug is fixed and obsolete limiter is removed in Source_Kin_K_Eps.f90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting the updates from the latest version...