Fix empty owners-to-ping in staleness comments #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablko
commented
Apr 25, 2022
| @@ -339,7 +339,7 @@ export function process(prInfo: BotResult, | |||
| // Has it: got no DT tests but is approved by DT modules and basically blocked by the DT maintainers - and it has been over 3 days? | |||
| // Send a message reminding them that they can un-block themselves by adding tests. | |||
| if (!info.hasTests && !info.hasMultiplePackages && info.approvedBy.includes("owner") && !info.editsInfra | |||
| && info.approverKind === "maintainer" && (info.staleness?.days ?? 0) > 3) { | |||
| && info.approverKind === "maintainer" && dayjs(info.now).diff(info.lastPushDate, "days") > 3) { | |||
There was a problem hiding this comment.
We don't apply the unreviewed timeline to these PRs anymore (ones in the maintainer queue with reviews). This replacement is the same as if we did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by a trivial cosmetic glitch (spurious
/) in theUnmerged:nearlycomment:It was introduced in a change that instead targeted this
Unreviewed:comment.The fix proposed here is, don't filter existing approvals out of
Unreviewed:(andUnmerged:) pings. Instead, don't apply the unreviewed label/timeline to PRs that have reviews and are already in the maintainer queue.The unreviewed timeline has two functions, I think:
It doesn't have a function if a PR in the maintainer queue has reviews?
The code already treats "unreviewed" as completely unreviewed vs. unreviewed by maintainers, I think:
dt-mergebot/src/comments.ts
Line 181 in 36ec63f
dt-mergebot/src/comments.ts
Line 185 in 36ec63f
This change:
Unmerged:andUnreviewed:comments).