Trigger bot to cleanup columns #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elibarzilay
force-pushed
the
master
branch
3 times, most recently
from
1d39a68
to
9e931d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about triggering the bot in the
--cleanupsection ofrun.ts, the same as it does on open PRs?The normal webhook behavior removes closed/draft PRs from the project board. We already call
executePrActions(), etc. inrun.ts, thereby removing any draft PRs that got missed, this PR does the same to cleanup any closed PRs. Makes the normal/cleanup cases share the same code. Also the closed/draft cases.Adds the PR number to the projectboard-cards query:
!cardIDs.includes()with!prs.includes()(excludes open PRs by PR number vs. card ID)cardIDsfrom the all-open-prs queryThe Recently Merged column still does its own thing because the bot doesn't normally remove anything from that column.