Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge and perform timeline actions #349

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Jan 21, 2021

Pedantic because:

  1. It's unlikely that anyone would request to merge in the interval between the timeline expiring and the bot closing the PR
  2. Because mergePullRequest comes before closePullRequest in getMutationsForChangingPRState(), I expect that the merge request would be honored anyway (closePullRequest would subsequently fail, and there'd be an extraneous Unmerged:done comment)

The fix is to only perform timeline actions if the PR isn't also about to be merged.

The follow-up commit combines shouldClose and shouldMerge, like #348, so it's obvious they're mutually exclusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant