Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put explanations next to lines in question #288

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Put explanations next to lines in question #288

wants to merge 21 commits into from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Dec 22, 2020

@elibarzilay
Copy link
Contributor

To reply to your comment from the other thread:

Can we put the explanation next to the line in question? I'll prepare a PR based on #265, minus the actual suggestions.

I'm guessing that "minus the actual suggestions" means not suggesting a fixed config--? If so, I specifically want to wait before making this done via a code review comment which sounds more formal. So instead I was thinking of a short parenthesized explanation (you edited foo, and therefore we need a human eye).

@jablko jablko force-pushed the patch-44 branch 4 times, most recently from aeb9fae to 5e370e0 Compare January 20, 2021 23:00
@elibarzilay elibarzilay force-pushed the master branch 3 times, most recently from 1d39a68 to 9e931d1 Compare July 7, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jablko @elibarzilay