Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signature of module #8998

Closed
wants to merge 2 commits into from
Closed

Update signature of module #8998

wants to merge 2 commits into from

Conversation

Zzzen
Copy link
Contributor

@Zzzen Zzzen commented Apr 15, 2016

Improvement to existing type definition.

  • documentation or source code reference which provides context for the suggested changes. url http://api.jquery.com/html .
    • it has been reviewed by a DefinitelyTyped member.

See issue #8996

@dt-bot
Copy link
Member

dt-bot commented Apr 15, 2016

blueimp-md5/blueimp-md5.d.ts

to author (@rmartone). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

Add an optional parameter which is available in higher version.
@vvakame
Copy link
Member

vvakame commented Apr 17, 2016

mongodb/mongodb.d.ts

to author (@CaselIT). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@CaselIT
Copy link
Contributor

CaselIT commented Apr 17, 2016

The find signature method you added in the mongodb definition is not for the nodejs api but for the mongo Shell. The nodejs api documentation does not list it.

@Zzzen
Copy link
Contributor Author

Zzzen commented Apr 18, 2016

It has been included in nodejs. See api.
collection.find(query[[[, fields], options], callback]);

fields - indicates which fields should be included in the response (default is all)

@CaselIT

@CaselIT
Copy link
Contributor

CaselIT commented Apr 18, 2016

@Zzzen The link you provided is the documentation for version 1.4.9.
It's been removed in the documentation for version 2.1. I've also asked about it and it's not a case of missing documentation

@Zzzen
Copy link
Contributor Author

Zzzen commented Apr 19, 2016

I see. So, how should I limit the fields to return? @CaselIT

@CaselIT
Copy link
Contributor

CaselIT commented Apr 19, 2016

Check che Cursor class, the objective returned by find. To limit the returned fields I think you can use the project method
http://mongodb.github.io/node-mongodb-native/2.1/api/Cursor.html

@Zzzen
Copy link
Contributor Author

Zzzen commented Apr 19, 2016

Thanks.

@CaselIT
Copy link
Contributor

CaselIT commented Apr 21, 2016

@Zzzen regarding the mongodb other find method signature, it will be added to the definition when this pr is merged #9064

@Zzzen Zzzen closed this Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants